Potential fix for NULL Pointer Dereference#337
Open
Johan-p wants to merge 2 commits intogildor2:masterfrom
Open
Potential fix for NULL Pointer Dereference#337Johan-p wants to merge 2 commits intogildor2:masterfrom
Johan-p wants to merge 2 commits intogildor2:masterfrom
Conversation
… to previous dereference This rule finds comparisons of a pointer to null that occur after a reference of that pointer. It's likely either the check is not required and can be removed, or it should be moved to before the dereference so that a null pointer dereference does not occur. Recommendation The check should be moved to before the dereference, in a way that prevents a null pointer value from being dereferenced. If it's clear that the pointer cannot be null, consider removing the check instead. References Null Dereference https://owasp.org/www-community/vulnerabilities/Null_Dereference Common Weakness Enumeration: CWE-476. https://cwe.mitre.org/data/definitions/476.html Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 1: Redundant null check due to previous dereference
Owner
|
Security scanners are paranoid, and fixing everything to make them happy is not a good idea. BTW this function is not used, so I can't see if there's any mistake there. It appears to me like I created it during development, but went a different way later. "Width" parameter is not going to be null for this call, according to comment in header file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a major issue but this one popped up after enabling the security code scan on the repo.
Potential fix for code scanning alert no. 1: Redundant null check due to previous dereference
This rule finds comparisons of a pointer to null that occur after a reference of that pointer. It's likely either the check is not required and can be removed, or it should be moved to before the dereference so that a null pointer dereference does not occur.
References
Null Dereference
https://owasp.org/www-community/vulnerabilities/Null_Dereference
Common Weakness Enumeration: CWE-476.
https://cwe.mitre.org/data/definitions/476.html