-
Notifications
You must be signed in to change notification settings - Fork 1
Pp 1477 android 16 testing #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project to support Android 16 testing by upgrading various build tools and adding temporary SDK limits to Robolectric tests. The changes include updating Android SDK versions, upgrading Gradle, Kotlin, and other dependencies, while adding temporary maxSdk configurations to prevent test failures.
- Updates Android compile and target SDK from 35 to 36
- Upgrades Gradle (8.7 → 8.13), Kotlin (1.9.25 → 2.1.0), and AGP (8.6.0 → 8.11.1)
- Adds temporary
@Config(maxSdk = 35)
annotations to Robolectric tests with TODO comments for future removal
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
gradle/libs.versions.toml | Updates SDK versions, Gradle, Kotlin, and dependency versions; adds compose-compiler plugin |
gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to version 8.13 |
Multiple test files | Adds temporary maxSdk = 35 configuration to prevent Robolectric test failures |
Multiple build.gradle.kts files | Adds compose-compiler plugin and updates Java version targets |
Comments suppressed due to low confidence (1)
gradle/libs.versions.toml:6
- Android Gradle Plugin version 8.11.1 does not exist. The latest stable version in the 8.x series is 8.7.x. Please verify this version exists before using it.
android-gradle-plugin = "8.11.1"
completableFuture = "org.glassfish.jersey.bundles.repackaged:jersey-jsr166e:2.25.1" | ||
truth = "com.google.truth:truth:1.1.3" | ||
robolectric = "org.robolectric:robolectric:4.14.1" | ||
#TODO: remove these todos: remove after upgrading to robolectric to 4.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment contains redundant text. It should be simplified to '#TODO: remove after upgrading to robolectric to 4.16' to avoid the repetitive 'remove these todos: remove'.
#TODO: remove these todos: remove after upgrading to robolectric to 4.16 | |
#TODO: remove after upgrading to robolectric to 4.16 |
Copilot uses AI. Check for mistakes.
No description provided.