PP-1700: Unit and Integration related to feature flag #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Journey feature flag PP-1700
obaidgini
requested review from
abolfazlimahdi,
MozhganPeivandianSharbaf and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive testing for the user analytics feature flag functionality, specifically testing how BufferedUserAnalyticsEventTracker behaves when the user journey analytics is enabled or disabled.
- Unit tests for
BufferedUserAnalyticsEventTrackerto verify tracker initialization based on feature flag state - Integration tests using
GiniCaptureFragmentto test the analytics behavior in a realistic scenario - Helper class to facilitate testing with mocked
GiniCaptureinstances
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| BufferedUserAnalyticsEventTrackerTest.kt | Comprehensive unit tests for analytics tracker behavior with feature flag |
| BufferedUserAnalyticsEventTracker.kt | Adds test-only method to expose internal trackers for verification |
| GiniCaptureFragmentTest.kt | Integration tests verifying analytics behavior through fragment lifecycle |
| GiniCaptureHelperForInstrumentationTests.java | Test helper to inject mocked GiniCapture instances |
| build.gradle.kts | Adds mockito-kotlin2 dependency for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...sdk/sdk/src/androidTest/java/net/gini/android/capture/ginicapture/GiniCaptureFragmentTest.kt
Show resolved
Hide resolved
...sdk/src/test/java/net/gini/android/capture/tracking/BufferedUserAnalyticsEventTrackerTest.kt
Outdated
Show resolved
Hide resolved
...sdk/src/test/java/net/gini/android/capture/tracking/BufferedUserAnalyticsEventTrackerTest.kt
Outdated
Show resolved
Hide resolved
...sdk/src/test/java/net/gini/android/capture/tracking/BufferedUserAnalyticsEventTrackerTest.kt
Outdated
Show resolved
Hide resolved
abolfazlimahdi
approved these changes
Sep 9, 2025
...sdk/sdk/src/androidTest/java/net/gini/android/capture/ginicapture/GiniCaptureFragmentTest.kt
Show resolved
Hide resolved
...sdk/src/test/java/net/gini/android/capture/tracking/BufferedUserAnalyticsEventTrackerTest.kt
Show resolved
Hide resolved
...sdk/src/test/java/net/gini/android/capture/tracking/BufferedUserAnalyticsEventTrackerTest.kt
Outdated
Show resolved
Hide resolved
…to PP-1700-unit-and-integration-tests
…r to return boolean for better testing PP-1700
…entTracker to return boolean for better testing PP-1700
…ntTracker to return boolean for better testing PP-1700
abolfazlimahdi
approved these changes
Oct 1, 2025
… definition of method. PP-1700
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BufferedUserAnalyticsEventTrackerBufferedUserAnalyticsEventTrackerGiniCaptureFragmentNetworkRequestsManagerImageMultiPageDocumentMemoryStoreGiniCaptureSome of the above mentioned classes are used for mocks only.
Notes for reviewer
Analytics for android uses multiple classes, please read the comments mentioned in
GiniCaptureFragmentTestand specially inBufferedUserAnalyticsEventTrackerTest. These comments explain how our analytics are working, and how we can test the behaviors.