PP 1763 DocumentAnalyzer screen issues #843
Merged
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors hardcoded log tag strings in the DocumentAnalyzer class to use a centralized constant for better maintainability and consistency.
- Introduces a companion object with a private LOG_TAG constant
- Replaces all hardcoded "gini-api" strings in Log.d() calls with the LOG_TAG constant
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
obaidgini
added
the
Sonar cloud fixes
obaidgini
reviewed
Oct 1, 2025
...-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt
Outdated
Show resolved
Hide resolved
obaidgini
requested changes
Oct 1, 2025
|
MozhganPeivandianSharbaf
merged commit e442076
into
PP-1508-Monorepo-SonarQube-maintenance-bank-sdk
15 checks passed
MozhganPeivandianSharbaf
deleted the
PP-1763-DocumentAnalyzer-screen-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PP-1763