PP 1772 LineItemsAdapter.kt issues #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comment to an empty override method implementation to clarify that the method intentionally performs no operation.
- Added a clarifying comment to the
unbind()method override
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
MozhganPeivandianSharbaf
changed the base branch from
main
to
PP-1508-Monorepo-SonarQube-maintenance-bank-sdk
obaidgini
added
the
Sonar cloud fixes
obaidgini
requested changes
Oct 13, 2025
There was a problem hiding this comment.
@MozhganPeivandianSharbaf Thanks, Can you please use same style comment for no-op for consistency?
For example in our current code for no-op we are mostly using this type of comment
/* no-op */
For reference you can check AnalysisScreenPresenterExtension, and then noOpListener
Thank you
|
abolfazlimahdi
approved these changes
Oct 14, 2025
MozhganPeivandianSharbaf
merged commit d9b681e
into
PP-1508-Monorepo-SonarQube-maintenance-bank-sdk
15 checks passed
MozhganPeivandianSharbaf
deleted the
PP-1772-LineItemsAdapter.kt-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PP-1772