refactor(bank-sdk): Remove resloveViewModel function from AndroidFrag… #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abolfazlimahdi
requested review from
Copilot,
MozhganPeivandianSharbaf and
obaidgini
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AndroidFragmentExt.kt file to remove dependency on Koin's internal APIs, specifically eliminating the use of @OptIn(KoinInternalApi::class) and resolveViewModel function. The change improves SDK compliance by avoiding deprecated internal APIs as requested by Atruvia.
- Replaced Koin's internal
resolveViewModelwith a customViewModelProvider.Factoryimplementation - Removed
@OptIn(KoinInternalApi::class)annotation and related internal API imports - Simplified function signatures by removing the
extrasProducerparameter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/di/koin/AndroidFragmentExt.kt
Show resolved
Hide resolved
bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/di/koin/AndroidFragmentExt.kt
Outdated
Show resolved
Hide resolved
|
abolfazlimahdi
force-pushed
the
PP-1725-remove-resolveViewModel-function
branch
from
0bc56f7 to
adc5912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request by Atruvia. We were using a Koin API, which required us to use @OptIn(KoinInternalApi::class)
which is not recommended to do, especially when developing an SDK. I resolved the issue by using a Factory method to provide the ViewModel for dependency injection.
Ticket: https://ginis.atlassian.net/browse/PP-1725