Pp 1067 remove trust kit from the codebase #823

ValentinaIancu-Gini · 2025-04-01T15:01:03Z

This pull request is removing the external dependency TrustKit and introducing Gini internal code for Pinning management.

PP-1067

…ation PP-1067

PP-1067

…lude pinning configuration PP-1067

PP-1067

… networking with Pinning certificates PP-1067

PP-1067

…itialise the SDK PP-1067

PP-1067

sonarqubecloud · 2025-04-08T13:47:23Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarQube Cloud

zladzeyka · 2025-04-22T12:03:55Z

BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift

+         * - Parameter customApiDomain:        A custom api domain string.
+         * - Parameter alternativeTokenSource: A protocol for using custom api access token
+         * - Parameter pinningConfig:          the configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]]
+         * - Parameter logLevel:               The log level. `LogLevel.none` by default.


Suggested change

* - Parameter logLevel: The log level. `LogLevel.none` by default.

* - Parameter logLevel: The desired log level. Defaults to `LogLevel.none`.

I will modify this in 3 other places since I copy pasted from anpother place :D

zladzeyka

@ValentinaIancu-Gini Amazing job!
I have only a couple of comment suggestions.

zladzeyka · 2025-04-22T12:06:09Z

BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift

+         * Creates a Gini Bank API Library to be used with a transparent proxy and a custom api access token source and certificate pinning configuration.
+         *
+         * - Parameter customApiDomain:        A custom api domain string.
+         * - Parameter alternativeTokenSource: A protocol for using custom api access token


Suggested change

* - Parameter alternativeTokenSource: A protocol for using custom api access token

* - Parameter alternativeTokenSource: A protocol-conforming instance used to provide a custom API access token.

zladzeyka · 2025-04-22T12:10:01Z

BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift

+         *
+         * - Parameter customApiDomain:        A custom api domain string.
+         * - Parameter alternativeTokenSource: A protocol for using custom api access token
+         * - Parameter pinningConfig:          the configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]]


Suggested change

* - Parameter pinningConfig: the configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]]

* - Parameter pinningConfig: A dictionary specifying the certificate pinning configuration in the format `["PinnedDomains": ["PublicKeyHashes"]]`.

zladzeyka · 2025-04-22T12:11:56Z

BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift

+        }
+
+        /**
+         * Creates a Gini Bank API Library to be used with a transparent proxy and a custom api access token source and certificate pinning configuration.


Suggested change

* Creates a Gini Bank API Library to be used with a transparent proxy and a custom api access token source and certificate pinning configuration.

* Initializes a Gini Bank API Library instance configured with a transparent proxy and a custom api access token source and certificate pinning.

zladzeyka · 2025-04-22T12:23:45Z

BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift

    }

+    /**
+     Initializes a new instance.


[Suggestion]: I think it makes sense to add Initializes a new instance of ObjectName

zladzeyka · 2025-04-22T12:28:34Z

BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/Networking/GiniBank+Networking.swift

-     - parameter trackingDelegate: A delegate object to receive user events.
-     - parameter networkingService: A delegate object which implement protocol for the document processing events.
-     - parameter configurationService: A delegate object which implement protocol for the customer configuration.
+     - Parameter importedDocuments: There should be either images or one PDF, and they should be validated before calling this method.


[Suggestion]: I think we can remove Parameter from each lines, you already doing it below, in Bank SDK

zladzeyka · 2025-04-22T12:41:22Z

BankSDK/GiniBankSDKExample/GiniBankSDKExample.xcodeproj/project.pbxproj

 				768100372996959800C52F87 /* CustomDigitalInvoiceOnboardingBottomNavigationBarAdapter.swift in Sources */,
 				28A570102D4276EB00A97EBC /* TransactionDetailsViewController.swift in Sources */,
-				28DAF4B62CD293B80035A1FF /* GiniBankSDKExampleUITests.swift in Sources */,
-				28DAF4BC2CD293C80035A1FF /* GiniReturnAssistantScreenUITests.swift in Sources */,


[Clarification]: Did we loose this file, I can't find it in + only in removed

No, we did not lose them. I don't know what was happening, but Recovered References was generated automatically, and I removed it in this pr. The files are still in the project.

PP-1067

…-from-the-codebase # Conflicts: # BankAPILibrary/GiniBankAPILibraryPinning/Package-release.swift # BankAPILibrary/GiniBankAPILibraryPinning/Package.swift # BankAPILibrary/GiniBankAPILibraryPinning/README.md # BankSDK/GiniBankSDKExample/Tests/IntegrationTests/BankAPILibrary/BankAPILibraryIntegrationTests.swift # BankSDK/GiniBankSDKPinning/Package-release.swift # BankSDK/GiniBankSDKPinning/Package.swift # BankSDK/GiniBankSDKPinning/README.md # BankSDK/GiniBankSDKPinningExample/GiniBankSDKExampleBank/PaymentViewController.swift # BankSDK/GiniBankSDKPinningExample/GiniBankSDKPinningExample.xcodeproj/project.pbxproj # BankSDK/GiniBankSDKPinningExample/Tests/BankAPILibraryPinning/GiniBankAPILibraryPinningIntegrationTests.swift # BankSDK/GiniBankSDKPinningExample/Tests/BankAPILibraryPinning/GiniBankAPILibraryPinningIntegrationWrongCertificatesTests.swift # CaptureSDK/GiniCaptureSDKPinning/Package-release.swift # CaptureSDK/GiniCaptureSDKPinning/Package.swift # CaptureSDK/GiniCaptureSDKPinning/README.md # RELEASE-ORDER.md

… pinning PP-1067

…-from-the-codebase # Conflicts: # BankAPILibrary/GiniBankAPILibrary/Documentation/source/Installation.md # BankAPILibrary/GiniBankAPILibraryPinning/Package-release.swift # BankAPILibrary/GiniBankAPILibraryPinning/Sources/GiniBankAPILibraryPinning/GiniBankAPILibraryPinningVersion.swift # BankSDK/GiniBankSDKExample/GiniBankSDKExample.xcodeproj/project.pbxproj # BankSDK/GiniBankSDKPinning/Package-release.swift # BankSDK/GiniBankSDKPinning/Package.swift # BankSDK/GiniBankSDKPinning/Pod/GiniBankSDKPinning.podspec # BankSDK/GiniBankSDKPinning/Sources/GiniBankSDKPinning/GiniBankSDKPinningVersion.swift # BankSDK/GiniBankSDKPinningExample/Tests/BankAPILibraryPinning/GiniBankAPILibraryPinningIntegrationTests.swift # BankSDK/GiniBankSDKPinningExample/Tests/TransferSummaryIntegrationTest.swift # CaptureSDK/GiniCaptureSDKPinning/Package-release.swift # CaptureSDK/GiniCaptureSDKPinning/Package.swift # CaptureSDK/GiniCaptureSDKPinning/Sources/GiniCaptureSDKPinning/GiniCaptureSDKPinningVersion.swift

sonarqubecloud · 2025-07-15T16:43:47Z

Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

…-from-the-codebase # Conflicts: # .github/workflows/bank-api-library.check.yml # .github/workflows/bank-api-library.release.yml # .github/workflows/bank-sdk.check.yml # .github/workflows/bank-sdk.release.yml # .github/workflows/capture-sdk.check.yml # .github/workflows/capture-sdk.release.yml # BankSDK/GiniBankSDKExample/GiniBankSDKExample.xcodeproj/project.pbxproj # BankSDK/GiniBankSDKPinning/Package-release.swift # BankSDK/GiniBankSDKPinning/Sources/GiniBankSDKPinning/GiniBankSDKPinningVersion.swift # CaptureSDK/GiniCaptureSDKPinning/.swiftpm/xcode/xcshareddata/xcschemes/GiniCaptureSDKPinning.xcscheme # CaptureSDK/GiniCaptureSDKPinning/Package-release.swift # CaptureSDK/GiniCaptureSDKPinning/Sources/GiniCaptureSDKPinning/GiniCaptureSDKPinningVersion.swift # GiniMobile.xcworkspace/xcshareddata/swiftpm/Package.resolved

sonarqubecloud · 2025-10-02T12:37:57Z

Quality Gate failed

Failed conditions
1 Security Hotspot
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

ValentinaIancu-Gini added 16 commits March 25, 2025 09:41

refactor(GiniBankAPILibrary): Remove pinning SPM

fa64e33

PP-1067

refactor(GiniCaptureSDK): Remove pinning SPM

5692de7

PP-1067

refactor(GiniBankSDK): Remove pinning SPM

dda7a3b

PP-1067

refactor(GiniBankSDK): Remove pinning example project

43f08ff

PP-1067

refactor(GiniBankSDK): Refactor unit tests for GalleryManager

10c1e2d

PP-1067

feat(GiniBankAPILibrary): Add Gini internal code for pinning configur…

95c7872

…ation PP-1067

feat(GiniBankAPILibrary): Update documentation after removing TrustKit

e7a24a3

PP-1067

feat(GiniBankAPILibrary): Update initializers in GiniBankAPI to inc…

69061ac

…lude pinning configuration PP-1067

fix(GiniCaptureSDK): Fix Xcode warnings

9e33332

PP-1067

feat(GiniBankSDKExample): Add example to test Screen API with default…

9d7689b

… networking with Pinning certificates PP-1067

feat(GiniBankSDKExample): Add integration tests for pinning

095b3b3

PP-1067

feat(GiniBankSDKExample): Add extra comment

6f745cd

PP-1067

feat(GiniBankSDK): Add methods to support pinning configuration to in…

cbb355d

…itialise the SDK PP-1067

fix(GiniBankSDK): Fix documentation style

3576416

PP-1067

fix(GiniBankAPILibrary): Update documentation after removing TrustKit

a8352c0

PP-1067

fix(GiniBankSDK): Fix documentation

30769c5

PP-1067

ValentinaIancu-Gini requested review from mrkulik and zladzeyka April 1, 2025 15:01

ValentinaIancu-Gini self-assigned this Apr 1, 2025

ValentinaIancu-Gini added 3 commits April 1, 2025 17:31

ci: Update workflows to remove pinning packages and projects

423d7ff

feat(GiniBankSDKExample): Remove pinning example app

4838493

PP-1067

fix(GiniBankAPILibrary): Update jazzy file

20fbc44

PP-1067

zladzeyka reviewed Apr 22, 2025

View reviewed changes

zladzeyka requested changes Apr 22, 2025

View reviewed changes

ValentinaIancu-Gini added 3 commits April 22, 2025 17:37

fix(GiniBankAPILibrary): Improve code documentation

f0f03a5

PP-1067

fix(GiniBankSDK): Improve code documentation

50ce79a

PP-1067

ValentinaIancu-Gini requested a review from zladzeyka April 22, 2025 15:56

fix(GiniBankSDKExample): Fix integration test for payment request for…

49cbfff

… pinning PP-1067

ValentinaIancu-Gini requested review from lestergini and qnaveed87 and removed request for mrkulik August 25, 2025 16:49

ValentinaIancu-Gini marked this pull request as draft August 25, 2025 16:50

ValentinaIancu-Gini requested a deployment to firebase-manual-deploy October 2, 2025 12:37 — with GitHub Actions Waiting

	* - Parameter logLevel: The log level. `LogLevel.none` by default.
	* - Parameter logLevel: The desired log level. Defaults to `LogLevel.none`.

	* - Parameter alternativeTokenSource: A protocol for using custom api access token
	* - Parameter alternativeTokenSource: A protocol-conforming instance used to provide a custom API access token.

	* - Parameter pinningConfig: the configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]]
	* - Parameter pinningConfig: A dictionary specifying the certificate pinning configuration in the format `["PinnedDomains": ["PublicKeyHashes"]]`.

	* Creates a Gini Bank API Library to be used with a transparent proxy and a custom api access token source and certificate pinning configuration.
	* Initializes a Gini Bank API Library instance configured with a transparent proxy and a custom api access token source and certificate pinning.

Pp 1067 remove trust kit from the codebase #823

Are you sure you want to change the base?

Pp 1067 remove trust kit from the codebase #823

Uh oh!

Conversation

ValentinaIancu-Gini commented Apr 1, 2025

Uh oh!

sonarqubecloud bot commented Apr 8, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zladzeyka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 15, 2025

Quality Gate failed

Uh oh!

sonarqubecloud bot commented Oct 2, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants