Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update to Gio 0.6 and Go 1.22 #69

Merged
merged 5 commits into from
Jun 9, 2024
Merged

all: update to Gio 0.6 and Go 1.22 #69

merged 5 commits into from
Jun 9, 2024

Conversation

inkeliz
Copy link
Contributor

@inkeliz inkeliz commented Jun 2, 2024

That change uses the new gtx.Execute. This change makes compatible with Gio 0.6. The plugins.Install was removed and replaced by gioplugins.Event(), README was updated to reflect such change.

Also, the wasm-import and InkWASM to be compatible with Go 1.20+ versions. The Explorer package was updated to be compatible with standard version of Go Compiler.

Fix #57
Fix #65
Fix #63
Fix #7

EDIT:

It requires changes in Gio-Core (either gioui/gio#136 or gioui/gio#134 must get accepted upstream). Currently, it assumes that Gio is gioui/gio#136. That is also why the current go.mod uses replace everywhere.

That change uses the new gtx.Execute. This change makes
compatible with Gio 0.6. The plugins.Install was removed
and replaced by gioplugins.Event(), README was updated
to reflect such change.

Also, the wasm-import and InkWASM to be compatible with
Go 1.20+ versions. The Explorer package was updated to
be compatible with standard version of Go Compiler.

Fix #57
Fix #65

Signed-off-by: inkeliz <inkeliz@inkeliz.com>
inkeliz added 3 commits June 3, 2024 11:02
Signed-off-by: inkeliz <inkeliz@inkeliz.com>
Signed-off-by: inkeliz <inkeliz@inkeliz.com>
Signed-off-by: inkeliz <inkeliz@inkeliz.com>
@gedw99
Copy link

gedw99 commented Jun 6, 2024

really hope that the GIO changes get through as this has been on hold for so long.

Signed-off-by: inkeliz <inkeliz@inkeliz.com>
@inkeliz inkeliz merged commit 48f2a32 into main Jun 9, 2024
@inkeliz
Copy link
Contributor Author

inkeliz commented Jun 10, 2024

It don't work with gtx.Event or gtx.Execute, instead gioplugins.Event(gtx, ...) and gioplugins.Execute(gtx, ...) must be used. That makes possible to use GioPlugins without any Gio change, of couse it's worse and more confusing, but works.

The old plugin.Install() was moved and renamed to gioplugins.Hijack(window).

@inkeliz inkeliz deleted the gio0.6 branch June 10, 2024 20:34
@gedw99
Copy link

gedw99 commented Jun 11, 2024

Thanks for the explanation @inkeliz

Well done . Amazing work.

I tested most of the plugins last night. All working for me. Works on windows arm64 too when I tried it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants