Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app,io/system: [API] add StageInactive when window is not in focus #92

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/internal/windows/windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ const (
WM_MOUSEMOVE = 0x0200
WM_MOUSEWHEEL = 0x020A
WM_MOUSEHWHEEL = 0x020E
WM_NCACTIVATE = 0x0086
WM_NCHITTEST = 0x0084
WM_PAINT = 0x000F
WM_QUIT = 0x0012
Expand Down
6 changes: 3 additions & 3 deletions app/os_android.go
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ func Java_org_gioui_GioView_onLowMemory(env *C.JNIEnv, class C.jclass) {
func Java_org_gioui_GioView_onConfigurationChanged(env *C.JNIEnv, class C.jclass, view C.jlong) {
w := cgo.Handle(view).Value().(*window)
w.loadConfig(env, class)
if w.stage >= system.StageRunning {
if w.stage >= system.StageInactive {
w.draw(env, true)
}
}
Expand All @@ -563,7 +563,7 @@ func Java_org_gioui_GioView_onFrameCallback(env *C.JNIEnv, class C.jclass, view
if !exist {
return
}
if w.stage < system.StageRunning {
if w.stage < system.StageInactive {
return
}
if w.animating {
Expand Down Expand Up @@ -596,7 +596,7 @@ func Java_org_gioui_GioView_onWindowInsets(env *C.JNIEnv, class C.jclass, view C
left: int(left),
right: int(right),
}
if w.stage >= system.StageRunning {
if w.stage >= system.StageInactive {
w.draw(env, true)
}
}
Expand Down
7 changes: 7 additions & 0 deletions app/os_macos.go
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,13 @@ func gio_onDraw(view C.CFTypeRef) {
func gio_onFocus(view C.CFTypeRef, focus C.int) {
w := mustView(view)
w.w.Event(key.FocusEvent{Focus: focus == 1})
if w.stage >= system.StageInactive {
if focus == 0 {
w.setStage(system.StageInactive)
} else {
w.setStage(system.StageRunning)
}
}
w.SetCursor(w.cursor)
}

Expand Down
8 changes: 8 additions & 0 deletions app/os_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,14 @@ func windowProc(hwnd syscall.Handle, msg uint32, wParam, lParam uintptr) uintptr
case windows.WM_KILLFOCUS:
w.focused = false
w.w.Event(key.FocusEvent{Focus: false})
case windows.WM_NCACTIVATE:
if w.stage >= system.StageInactive {
if wParam == windows.TRUE {
w.setStage(system.StageRunning)
} else {
w.setStage(system.StageInactive)
}
}
case windows.WM_NCHITTEST:
if w.config.Decorated {
// Let the system handle it.
Expand Down
6 changes: 3 additions & 3 deletions app/window.go
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ func (w *Window) driverDefer(f func(d driver)) {

func (w *Window) updateAnimation(d driver) {
animate := false
if w.stage >= system.StageRunning && w.hasNextFrame {
if w.stage >= system.StageInactive && w.hasNextFrame {
if dt := time.Until(w.nextFrame); dt <= 0 {
animate = true
} else {
Expand Down Expand Up @@ -826,7 +826,7 @@ func (w *Window) processEvent(d driver, e event.Event) bool {
}
switch e2 := e.(type) {
case system.StageEvent:
if e2.Stage < system.StageRunning {
if e2.Stage < system.StageInactive {
if w.gpu != nil {
w.ctx.Lock()
w.gpu.Release()
Expand All @@ -842,7 +842,7 @@ func (w *Window) processEvent(d driver, e event.Event) bool {
if e2.Size == (image.Point{}) {
panic(errors.New("internal error: zero-sized Draw"))
}
if w.stage < system.StageRunning {
if w.stage < system.StageInactive {
// No drawing if not visible.
break
}
Expand Down
13 changes: 10 additions & 3 deletions io/system/system.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,24 @@ type StageEvent struct {
type Stage uint8

const (
// StagePaused is the Stage for inactive Windows.
// Inactive Windows don't receive FrameEvents.
// StagePaused is the stage for windows that have no on-screen representation.
// Paused windows don't receive FrameEvent.
inkeliz marked this conversation as resolved.
Show resolved Hide resolved
StagePaused Stage = iota
// StateRunning is for active Windows.
// StageInactive is the stage for windows that are visible, but not active.
// Inactive windows receive FrameEvent.
inkeliz marked this conversation as resolved.
Show resolved Hide resolved
StageInactive
// StageRunning is for active and visible Windows.
// Running windows receive FrameEvent.
StageRunning
)

// String implements fmt.Stringer.
func (l Stage) String() string {
switch l {
case StagePaused:
return "StagePaused"
case StageInactive:
return "StageInactive"
case StageRunning:
return "StageRunning"
default:
Expand Down