feat: table accompagnateurs + enrichissement et nettoyage de tables + documentation #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurinehu
changed the title
ikarius
approved these changes
Feb 6, 2025
ikarius
reviewed
Feb 6, 2025
| @@ -13,8 +14,6 @@ final AS ( | |||
| email, | |||
| last_name, | |||
| first_name, | |||
| is_valid, | |||
| is_staff, | |||
There was a problem hiding this comment.
nit : d'une manière générale, pour du reporting pourquoi on laisse les is_staff ? (à moins que ce soit filtré ailleurs)
There was a problem hiding this comment.
on ne les garde pas ! c'est bien filtré ici, ligne 7, donc stg_user ne contient que les users hors staff
jbuget
requested changes
Feb 7, 2025
| @@ -0,0 +1,50 @@ | |||
| models: | |||
| - name: int_accompagnateurs | |||
There was a problem hiding this comment.
Suggested change
| - name: int_accompagnateurs | |
| - name: int_prescribers |
| description: | ||
| Catégories de services. | ||
|
|
||
| - name: int_service_fundinglabels |
There was a problem hiding this comment.
Suggested change
| - name: int_service_fundinglabels | |
| - name: int_service_funding_labels |
| description: | ||
| Vues de pages par les utilisateurs. | ||
|
|
||
| - name: int_searchview_user |
There was a problem hiding this comment.
Suggested change
| - name: int_searchview_user | |
| - name: int_user_search_views |
| description: | ||
| Orientations des utilisateurs vers des services. | ||
|
|
||
| - name: int_pageview_user |
There was a problem hiding this comment.
Suggested change
| - name: int_pageview_user | |
| - name: int_user_page_views |
| Accompagnateurs avec le label national de leur structure. | ||
| `user_id` n'est pas une clé d'unicité étant donné qu'un utilisateur peut avoir de 0 à n labels. | ||
|
|
||
| - name: int_mobilisationevent_user |
There was a problem hiding this comment.
Suggested change
| - name: int_mobilisationevent_user | |
| - name: int_user_mobilization_events |
| description: | ||
| Labels des structures de services. | ||
|
|
||
| - name: int_serviceview_user_service |
There was a problem hiding this comment.
Suggested change
| - name: int_serviceview_user_service | |
| - name: int_user_service_views |
| description: | ||
| Vues de services par les utilisateurs. | ||
|
|
||
| - name: int_structure_labels |
There was a problem hiding this comment.
Suggested change
| - name: int_structure_labels | |
| - name: int_structure_national_labels |
| Labels nationaux associés aux structures. | ||
| `structure_id` n'est pas une clé d'unicité étant donné qu'une structure peut avoir de 0 à n labels. | ||
|
|
||
| - name: int_structure_member |
There was a problem hiding this comment.
Suggested change
| - name: int_structure_member | |
| - name: int_structure_members |
| SELECT | ||
| {{ dbt_utils.star(relation_alias='struct_member', from=ref('int_structure_member')) }}, | ||
| struct_labels.national_label_name | ||
| FROM {{ ref('int_structure_member') }} AS struct_member |
There was a problem hiding this comment.
Suggested change
| FROM {{ ref('int_structure_member') }} AS struct_member | |
| FROM {{ ref('int_structure_members') }} AS struct_member |
| @@ -0,0 +1,7 @@ | |||
| SELECT | |||
| {{ dbt_utils.star(relation_alias='struct_member', from=ref('int_structure_member')) }}, | |||
There was a problem hiding this comment.
Suggested change
| {{ dbt_utils.star(relation_alias='struct_member', from=ref('int_structure_member')) }}, | |
| {{ dbt_utils.star(relation_alias='struct_member', from=ref('int_structure_members')) }}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥝 Besoin
Créer des indicateurs de suivi des accompagnateurs.
🍅 Solution
Création à partir de la table
structure_memberd'une table filtrée sur les accompagnateurs et accompagnateurs_offreurs, ajout du label national de la structure pour pouvoir identifier les accompagnateurs FT, CD etc.🍇 Autre
J'en profite pour faire un peu de ménage et documenter les tables intermediate