-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2785 - Diagoriente par défaut dans la recherche #2950
#2785 - Diagoriente par défaut dans la recherche #2950
Conversation
enguerranws
commented
Feb 6, 2025
•
edited
Loading
edited
- prévoir la redirection recherche-diagoriente -> recherche
location = /recherche-diagoriente { | ||
return 301 $scheme://$http_host/recherche; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tu veux pas le faire simplement coté front ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ben j'aime autant que ce soit le serveur qui fasse la redirection direct, sans rentrer jusqu'au front.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
et puis là, le serveur va renvoyer un code 301, propre, le client ne retournera plus sur recherche-diagoriente
@@ -86,7 +86,10 @@ export const AppellationAutocomplete = ({ | |||
debounceSearchTerm: string; | |||
searchTerm: string; | |||
}) => { | |||
if (!searchTerm) return "Saisissez un métier"; | |||
if (!searchTerm) | |||
return useNaturalLanguage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
est-ce que ce booléan est toujours utile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui, je me disais, au cas où, pour rollback
@@ -288,10 +288,6 @@ export const { RouteProvider, useRoute, routes } = createRouter({ | |||
() => `/${frontRoutes.magicLinkRenewal}`, | |||
), | |||
search: defineRoute(searchParams, () => `/${frontRoutes.search}`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pour avoir le redirect ici (pour éviter les config nginx), on peut faire :
search: defineRoute(searchParams, () => `/${frontRoutes.search}`), | |
search: defineRoute(searchParams, () => [`/${frontRoutes.search}`, "/recheche-diagoriente"]), |
(pas de préférence, je te laisse le choix)
e02fab2
to
ce10770
Compare
Review app: |