Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2785 - Diagoriente par défaut dans la recherche #2950

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

enguerranws
Copy link
Contributor

@enguerranws enguerranws commented Feb 6, 2025

  • prévoir la redirection recherche-diagoriente -> recherche

@enguerranws enguerranws self-assigned this Feb 6, 2025
@enguerranws enguerranws linked an issue Feb 6, 2025 that may be closed by this pull request
@enguerranws enguerranws changed the title removed legacy search, search is now using diagoriente #2785 - Diagoriente par défaut dans la recherche Feb 6, 2025
Comment on lines +31 to +33
location = /recherche-diagoriente {
return 301 $scheme://$http_host/recherche;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu veux pas le faire simplement coté front ? 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ben j'aime autant que ce soit le serveur qui fasse la redirection direct, sans rentrer jusqu'au front.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

et puis là, le serveur va renvoyer un code 301, propre, le client ne retournera plus sur recherche-diagoriente

@@ -86,7 +86,10 @@ export const AppellationAutocomplete = ({
debounceSearchTerm: string;
searchTerm: string;
}) => {
if (!searchTerm) return "Saisissez un métier";
if (!searchTerm)
return useNaturalLanguage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est-ce que ce booléan est toujours utile ? 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, je me disais, au cas où, pour rollback

@@ -288,10 +288,6 @@ export const { RouteProvider, useRoute, routes } = createRouter({
() => `/${frontRoutes.magicLinkRenewal}`,
),
search: defineRoute(searchParams, () => `/${frontRoutes.search}`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour avoir le redirect ici (pour éviter les config nginx), on peut faire :

Suggested change
search: defineRoute(searchParams, () => `/${frontRoutes.search}`),
search: defineRoute(searchParams, () => [`/${frontRoutes.search}`, "/recheche-diagoriente"]),

(pas de préférence, je te laisse le choix)

@enguerranws enguerranws force-pushed the 2785-suppression-de-lab-test-sur-diagoriente branch from e02fab2 to ce10770 Compare February 11, 2025 10:04
Copy link

@enguerranws enguerranws merged commit f84cb88 into main Feb 11, 2025
12 checks passed
@enguerranws enguerranws deleted the 2785-suppression-de-lab-test-sur-diagoriente branch February 11, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppression de l'A/B test sur Diagoriente
2 participants