TECH - Ajout de cache sur les appels LBB #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celineung
force-pushed
the
tech-add-cach-lbb
branch
2 times, most recently
from
d6d8e37 to
0da64eb
Compare
celineung
changed the title
celineung
force-pushed
the
tech-add-cach-lbb
branch
from
0da64eb to
86c316d
Compare
|
Review app: |
JeromeBu
reviewed
Feb 11, 2025
back/src/domains/establishment/adapters/la-bonne-boite/HttpLaBonneBoiteGateway.ts
Outdated
Show resolved
Hide resolved
celineung
force-pushed
the
tech-add-cach-lbb
branch
from
86c316d to
e8f3576
Compare
celineung
force-pushed
the
tech-add-cach-lbb
branch
from
e8f3576 to
d85e724
Compare
celineung
force-pushed
the
tech-add-cach-lbb
branch
from
d85e724 to
a271260
Compare
JeromeBu
approved these changes
Feb 12, 2025
Comment on lines
173
to
181
| .catch((error) => { | ||
| logger.error({ | ||
| error: castError(error), | ||
| message: "fetchCompanyBySiret_error", | ||
| siret, | ||
| }, | ||
| romeLabel: romeDto.romeLabel, | ||
| }); | ||
| throw error; | ||
| }), |
There was a problem hiding this comment.
je pense qu'on peut virer ce log (et tout le bloc de catch), maintenant qu'on a ceux de shared-routes
celineung
force-pushed
the
tech-add-cach-lbb
branch
from
cc466f5 to
526521d
Compare
celineung
force-pushed
the
tech-add-cach-lbb
branch
from
526521d to
2068f20
Compare
celineung
force-pushed
the
tech-add-cach-lbb
branch
from
2068f20 to
1bf4d9e
Compare
JeromeBu
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nous avons des erreurs 429 sur nos appels à LBB (trop de requêtes).
Pour éviter cela, nous mettons en place le cache sur ces appels.