Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDP issue ☹️ #397

Merged
merged 1 commit into from
Jan 23, 2025
Merged

FDP issue ☹️ #397

merged 1 commit into from
Jan 23, 2025

Conversation

laurinehu
Copy link
Contributor

**Carte Notion : **

Pourquoi ?

  • il manquait les {{ ref(' ') }}
  • besoin de sortir les tables de staging pour éviter les pbs de mémoire liées à l'union de stg

Checks

  • J'ai lancé le modèle ou seed sur un dump local (si pertinent)
  • J'ai ajouté des tests à mon code Python, ou des assertions DBT sur le modèle SQL
  • J'ai documenté ce modèle voire certains de ses champs (usage métier, tableau de bord, etc)

@laurinehu laurinehu force-pushed the laurinehu/metier_fdp branch from b44c110 to 90f5afe Compare January 23, 2025 10:52
@laurinehu laurinehu marked this pull request as ready for review January 23, 2025 10:52
YannickPassa
YannickPassa approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@YannickPassa YannickPassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok et désolé pour l'oubli des ref ouah

@laurinehu laurinehu self-assigned this Jan 23, 2025
@laurinehu laurinehu added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit d8fe578 Jan 23, 2025
5 checks passed
@laurinehu laurinehu deleted the laurinehu/metier_fdp branch January 23, 2025 15:36
@laurinehu
Copy link
Contributor Author

@YannickPassa ce serait cool qu'on puisse être alerté par la CI pfiou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannickPassa YannickPassa YannickPassa approved these changes

Assignees

@laurinehu laurinehu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurinehu @YannickPassa