Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add valueOpts to return result #21

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix add valueOpts to return result #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ooui/graph/chart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def process(self, values, fields, options=None):
if self.type == "line" and self.y_range:
y_axis_props = {'mode': self.y_range}
if self.y_range == "auto":
y_axis_props.update(get_min_max(final_data))
y_axis_props['valueOpts'] = get_min_max(final_data)
result['yAxisProps'] = y_axis_props

return result
return result
6 changes: 4 additions & 2 deletions spec/graph/graph_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@
result = graph.process(values, fields)
expect(result['yAxisProps']).to(equal({
'mode': 'auto',
'min': 8,
'max': 32
'valueOpts': {
'min': 8,
'max': 32
}
}))
with description("A line graph with y_range to full"):
with it("should return yAxisProps to the result with mode full"):
Expand Down
Loading