-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(bitbucket): detect expired OAuth credentials #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
becm
wants to merge
1
commit into
git-ecosystem:main
Choose a base branch
from
becm:bitbucket-oauth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes git-ecosystem#1775 credentials MUST be valid for OAuth and/or BasicAuth modes credentials SHOULD be considered invalid on auth mode mismatch setting override exists to skip credential expiry checks
Hey @becm, please find attached the log files. This log comes from a "git fetch" with still valid access_token and "bitbucketAlwaysRefreshCredentials = false". For me, this looks good so far. I will re-record the log with expired access_token in 1-2h.
|
Once again, now a log with expired credentials
|
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code flow for OAuth-only authMode must report back credential expiry correctly.
If neither of the supported modes is selected, this constitutes an invalid configuration anyway.
Better let more sophisticated existing parts of the code (token refresh/create) deal with this inconsistency.
Resolves #1775