Count on Issue labeled, removed unecessary get_installation_id function, and disabled Sentry in local env #39
Conversation
nikitamalinov
changed the title
nikitamalinov
changed the title
| def increment_request_count(self, installation_id: int) -> None: | ||
| data, _ = self.client.table(table_name="repo_info").select("*").eq(column="installation_id", value=installation_id).execute() | ||
| if (data[1] and data[1][0]): | ||
| self.client.table(table_name="repo_info").update(json={"requests": data[1][0]['requests'] + 1}).eq(column="installation_id", value=installation_id).execute() |
There was a problem hiding this comment.
If for some reason it fails, I would like the log to be worn.
There was a problem hiding this comment.
So this should be the case with the other two functions in the supabase_manager right?
There was a problem hiding this comment.
Yes, but the other functions can be modified next time.
Also I was a little vague in my expression. While the error log should be sent out, this process itself is not related to the main process, so it is better not to raise an error. If it is placed at the end of the main process, it is OK to raise the error.
There was a problem hiding this comment.
- If it involves database changes, I would like to be able to see it in the PR.
- Also, we need to ensure that the changes are included in the production DB along with the PR, or it will cause production errors. Is there a good way to ensure this?
- Also, this would out-date everyone's dev and stg environments in Supabase except who raised this PR. We can handle that right now, but is there a better way?
There was a problem hiding this comment.
There's no DB change, that's why I am doing requests only and i/o of tokens later. I think for your #3 it makes sense to migrate right before deploying. If it's a breaking DB change, we can set aside a time when no one is using our product to implement those changes.
There was a problem hiding this comment.
Really? I don't think requests and invoice_no columns existed before...
get_installation_id