Skip to content

feat: add non-archived branch getter #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Dec 11, 2024

☕️ Reasoning

  • We were using validSeries.filter((s) => !s.archived) all over the place, therefore added validNonArchivedBranch getter in its place.

🧢 Changes

  • Add additoinal getter, next to validSeries for validNonArchivedSeries
  • Renamed validSeries* to validBranches*

@vercel vercel bot temporarily deployed to Preview – gitbutler-web December 11, 2024 15:38 Inactive
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:57pm
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:57pm

@ndom91
Copy link
Contributor Author

ndom91 commented Dec 12, 2024

@Caleb-T-Owens p.s. just wanted to put this PR into your notifications for later 😉

@ndom91
Copy link
Contributor Author

ndom91 commented Dec 12, 2024

@Caleb-T-Owens p.s. just wanted to put this PR into your notifications for later 😉

@krlvi
Copy link
Member

krlvi commented Apr 29, 2025

This is now massively out of date with all the refactors.

@krlvi krlvi closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants