Skip to content

Commit

Permalink
t: clean up leftover reftable test cruft
Browse files Browse the repository at this point in the history
With the migration of reftable tests to the unit-tests framework,
"test-tool reftable" becomes a no-op.

Get rid of everything that uses "test-tool reftable" alongside
everything that is used to implement it.

While at it, alphabetically sort the cmds[] list in
helper/test-tool.c by moving the entry for "dump-reftable".

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
  • Loading branch information
gitster authored and Chandra Pratap committed Sep 6, 2024
1 parent 05e4b7e commit 43c1a52
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 126 deletions.
13 changes: 0 additions & 13 deletions reftable/reftable-tests.h

This file was deleted.

27 changes: 0 additions & 27 deletions reftable/test_framework.c

This file was deleted.

61 changes: 0 additions & 61 deletions reftable/test_framework.h

This file was deleted.

6 changes: 0 additions & 6 deletions t/helper/test-reftable.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@
#include "reftable/reftable-tests.h"
#include "test-tool.h"

int cmd__reftable(int argc, const char **argv)
{
/* test from simple to complex. */
return 0;
}

static void print_help(void)
{
printf("usage: dump [-st] arg\n\n"
Expand Down
3 changes: 1 addition & 2 deletions t/helper/test-tool.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ static struct test_cmd cmds[] = {
{ "drop-caches", cmd__drop_caches },
{ "dump-cache-tree", cmd__dump_cache_tree },
{ "dump-fsmonitor", cmd__dump_fsmonitor },
{ "dump-reftable", cmd__dump_reftable },
{ "dump-split-index", cmd__dump_split_index },
{ "dump-untracked-cache", cmd__dump_untracked_cache },
{ "env-helper", cmd__env_helper },
Expand Down Expand Up @@ -61,9 +62,7 @@ static struct test_cmd cmds[] = {
{ "read-graph", cmd__read_graph },
{ "read-midx", cmd__read_midx },
{ "ref-store", cmd__ref_store },
{ "reftable", cmd__reftable },
{ "rot13-filter", cmd__rot13_filter },
{ "dump-reftable", cmd__dump_reftable },
{ "regex", cmd__regex },
{ "repository", cmd__repository },
{ "revision-walking", cmd__revision_walking },
Expand Down
1 change: 0 additions & 1 deletion t/helper/test-tool.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ int cmd__read_graph(int argc, const char **argv);
int cmd__read_midx(int argc, const char **argv);
int cmd__ref_store(int argc, const char **argv);
int cmd__rot13_filter(int argc, const char **argv);
int cmd__reftable(int argc, const char **argv);
int cmd__regex(int argc, const char **argv);
int cmd__repository(int argc, const char **argv);
int cmd__revision_walking(int argc, const char **argv);
Expand Down
16 changes: 0 additions & 16 deletions t/t0032-reftable-unittest.sh

This file was deleted.

0 comments on commit 43c1a52

Please sign in to comment.