strvec: drop unnecessary include of hex.h

[listx]

In 41771fa (cache.h: remove dependence on hex.h; make other files include it explicitly, 2023-02-24) we added this as part of a larger mechanical refactor. But strvec doesn't actually depend on hex.h, so remove it.

cc: Jonathan Tan jonathantanmy@google.com
cc: Calvin Wan calvinwan@google.com

[listx]

/submit

[gitgitgadget]

Submitted as pull.1608.git.1698958277454.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1608/listx/strvec-cleanup-v1

To fetch this version to local tag pr-1608/listx/strvec-cleanup-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1608/listx/strvec-cleanup-v1

[gitgitgadget]

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Linus Arver <linusa@google.com>
>
> In 41771fa435 (cache.h: remove dependence on hex.h; make other files
> include it explicitly, 2023-02-24) we added this as part of a larger
> mechanical refactor. But strvec doesn't actually depend on hex.h, so
> remove it.
>
> Signed-off-by: Linus Arver <linusa@google.com>
> ---
>     strvec: drop unnecessary include of hex.h
>     
>     In 41771fa435 (cache.h: remove dependence on hex.h; make other files
>     include it explicitly, 2023-02-24) we added this as part of a larger
>     mechanical refactor. But strvec doesn't actually depend on hex.h, so
>     remove it.

This change somehow looks familiar.

> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1608
>
>  strvec.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/strvec.c b/strvec.c
> index 89dc9e7e753..178f4f37480 100644
> --- a/strvec.c
> +++ b/strvec.c
> @@ -1,6 +1,5 @@
>  #include "git-compat-util.h"
>  #include "strvec.h"
> -#include "hex.h"
>  #include "strbuf.h"

Makes sense.
Will queue.

Thanks.

[gitgitgadget]

This branch is now known as la/strvec-header-fix.

[gitgitgadget]

This patch series was integrated into seen via git@4b66cb8.

[gitgitgadget]

This patch series was integrated into next via git@db23d8a.

[gitgitgadget]

This patch series was integrated into seen via git@2e4d6fb.

[gitgitgadget]

There was a status update in the "New Topics" section about the branch la/strvec-header-fix on the Git mailing list:

Code clean-up.

Will merge to 'master'.
source: <pull.1608.git.1698958277454.gitgitgadget@gmail.com>

[gitgitgadget]

This patch series was integrated into seen via git@c1a4e96.

[gitgitgadget]

This patch series was integrated into seen via git@ca320b2.

[gitgitgadget]

This patch series was integrated into master via git@ca320b2.

[gitgitgadget]

This patch series was integrated into next via git@ca320b2.

[gitgitgadget]

Closed via ca320b2.