Let --find-objects find top-level trees by their OID, too
#1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: add test, document that `-c` and `--cc` are buggy and show commit headers even though the pickaxe machinery does not select the commit. Due to technical reasons, the diff machinery does not print out the root tree of any given commit when running with the `-t` option (for details, see https://git-scm.com/docs/git-log#Documentation/git-log.txt--t). However, quite often that is precisely what I need to find: the commit that introduced a certain change that ended up with the exact problematic (recursive) tree shape. The underlying problem is that the layer at which `-t` prints entries is when iterating the tree items, but the root tree is not a child of another tree, therefore it is never reached through such an iteration. So let's fudge things by specifically adding the root tree OID into the `objfind` set for commits that change the top-level tree. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add test, document that
-cand--ccare buggy and show commit headers even though the pickaxe machinery does not select the commit.