-
Notifications
You must be signed in to change notification settings - Fork 6
chore(agent): consider no status as completed for breakouts #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Seems like we're seeing agent trying to apply breakouts on some switches again and again as gNMI isn't showing Completed status for some breakouts for some reason. CLI still shows them as completed so it seems safe to assume no status is completed as well. Related githedgehog/internal#239 Signed-off-by: Sergei Lukianov <me@slukjanov.name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the agent's breakout handling logic to treat missing status as "Completed" to prevent repeated breakout attempts on switches where gNMI doesn't report status correctly.
Key Changes
- Modified status validation logic to handle nil status as completed state
- Added explanatory comment about the new behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🚀 Temp artifacts published: |
|
@pau-hedgehog could you please test it on both ds5k and ds3k by changing breakouts to make sure that we aren't facing any new issue with ports e.g. it may cause another issue when breakout isn't fully completed but we already try to configure resulting ports and we'll get an issue that some port doesn't exist |
|
When running the RoCE Release Tests I'm hitting this on |
|
🚀 Temp artifacts published: |
|
@pau-hedgehog that doesn't look related... Could you please create a separate bug for attempting to set breakouts when lossless mode is enabled? |
Opened: #1129 |
|
Going to test this with: |
Seems like we're seeing agent trying to apply breakouts on some switches again and again as gNMI isn't showing Completed status for some breakouts for some reason. CLI still shows them as completed so it seems safe to assume no status is completed as well.
Related githedgehog/internal#239