Skip to content

Fixes for external routing #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for external routing #1176

wants to merge 3 commits into from

Conversation

@edipascale
Copy link
Contributor

@edipascale edipascale commented Nov 4, 2025

Fixes #1175

@edipascale edipascale added ci:+hlab Enable hybrid VLAB tests ci:+release Enable VLAB release tests labels Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🚀 Temp artifacts published: v0-f58edb0bc 🚀

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🚀 Temp artifacts published: v0-f58edb0bc 🚀

@edipascale
Copy link
Contributor Author

edipascale commented Nov 4, 2025

I've tested this manually on env-5, and I ran release-test too to check we are not breaking anything:

08:44:42 INF *** Recap of the test results ***
08:44:42 INF Test suite results suite="No VPCs Suite"
08:44:42 INF PASS test="Breakout ports"
08:44:42 INF PASS test="Loki Observability"
08:44:42 INF PASS test="Prometheus Observability"
08:44:42 INF Test suite summary tests=3 passed=3 skipped=0 failed=0 duration=2m47s
08:44:42 INF Test suite results suite="Single VPC Suite"
08:44:42 INF PASS test="No restrictions"
08:44:42 INF PASS test="Single VPC with restrictions"
08:44:42 INF PASS test="DNS/NTP/MTU/DHCP lease"
08:44:42 WRN SKIP test="MCLAG Failover" reason="no MCLAG connections found"
08:44:42 WRN SKIP test="ESLAG Failover" reason="L3VNI mode is not compatible with ESLAG"
08:44:42 INF PASS test="Bundled Failover"
08:44:42 WRN SKIP test="Spine Failover" reason="not enough spines found"
08:44:42 WRN SKIP test="Mesh Failover" reason="There are no mesh (i.e. leaf-leaf) links between the switches"
08:44:42 INF PASS test="RoCE flag and basic traffic marking"
08:44:42 INF Test suite summary tests=9 passed=5 skipped=4 failed=0 duration=25m57s
08:44:42 INF Test suite results suite="Multi-Subnets VPC Suite"
08:44:42 INF PASS test="Multi-Subnets no restrictions"
08:44:42 INF PASS test="Multi-Subnets isolation"
08:44:42 INF PASS test="Multi-Subnets with filtering"
08:44:42 INF PASS test=StaticExternal
08:44:42 INF Test suite summary tests=4 passed=4 skipped=0 failed=0 duration=18m2s
08:44:42 INF Test suite results suite="Basic VPC Peering Suite"
08:44:42 WRN SKIP test="Starter Test" reason="not enough VPCs found"
08:44:42 INF PASS test="Only Externals"
08:44:42 INF PASS test="Full Mesh All Externals"
08:44:42 INF PASS test="Full Loop All Externals"
08:44:42 INF PASS test="Sergei's Special Test"
08:44:42 INF PASS test="Gateway Peering"
08:44:42 INF PASS test="Gateway Peering Loop"
08:44:42 INF PASS test="Mixed VPC and Gateway Peering Loop"
08:44:42 INF Test suite summary tests=8 passed=7 skipped=1 failed=0 duration=25m36s
08:44:42 INF All tests completed duration=1h12m22.148592731s

@edipascale edipascale marked this pull request as ready for review November 4, 2025 18:07
@edipascale edipascale requested a review from a team as a code owner November 4, 2025 18:07
@edipascale
Copy link
Contributor Author

edipascale commented Nov 4, 2025

See #1175 (comment) for an explanation of what we are doing here.

As a side note, an upgrade job has failed with a DHCP test failure, probably worth looking into this given the recent changes there @pau-hedgehog @Frostman

@Frostman
Copy link
Member

Frostman commented Nov 5, 2025

@pau-hedgehog could you please take a look at it https://github.com/githedgehog/fabric/actions/runs/19074020190/job/54485354377?pr=1176 ?

@pau-hedgehog
Copy link
Contributor

pau-hedgehog commented Nov 5, 2025

@pau-hedgehog could you please take a look at it https://github.com/githedgehog/fabric/actions/runs/19074020190/job/54485354377?pr=1176 ?

Couldn't find anything relevant in the artifacts: githedgehog/fabricator#1096
I will try to reproduce

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

🚀 Temp artifacts published: v0-f58edb0bc 🚀

@edipascale
fix(agent): filter imports in external VRF
0455be2 
only import prefixes belonging to the external's IPv4 namespace

Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
@edipascale
fix(agent): prefer external routes in ext. VRF
ad47e24 
to ensure we do not overwrite them with routes learned
from EVPN peers (e.g. another border leaf attached to
the external)

Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
@edipascale
fix(agent): prevent peering via external IRB VLAN
51ba7a7 
Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
@edipascale edipascale force-pushed the ema/fix-external-leaking branch from f58edb0 to 51ba7a7 Compare November 7, 2025 08:04
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🚀 Temp artifacts published: v0-51ba7a712 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci:+hlab Enable hybrid VLAB tests ci:+release Enable VLAB release tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Peering two VPCs to an external via the gateway makes them able to ping each other

4 participants

@edipascale @Frostman @pau-hedgehog