-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger show-tech in case of VM postProcess timeout #349
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
dd2dfba
to
8885daa
Compare
Maybe we should also try to capture show-tech when other on-ready commands fail: https://github.com/githedgehog/fabricator/actions/runs/13070506705/job/36471259713 In principle it's there but not working:
|
@@ -400,25 +400,26 @@ func (c *Config) VLABRun(ctx context.Context, vlab *VLAB, opts VLABRunOpts) erro | |||
if vm.Type == VMTypeServer || vm.Type == VMTypeControl { | |||
postProcesses.Add(1) | |||
group.Go(func() error { | |||
defer postProcesses.Done() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having defer ...Done() will break the logic of post actions, I need to dig deeper to understand if it's a problem
We are facing several CI failure conditions where show-tech is not executed and thus we cannot diagnose the root cause
Related to #333