-
Notifications
You must be signed in to change notification settings - Fork 5
fix(versions): log release versions when config is missing #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a003bb
to
3785e41
Compare
I'm removing the |
4a2bd42
to
fc41208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OUTDATED -- Pull Request Overview
This PR enhances the versions
command to:
- Fallback to printing built-in release versions when no
fab.yaml
is found - Introduce a
--live
flag to fetch versions from a running Fabricator in-cluster - Update CI workflows to invoke
bin/hhfab versions
and remove the oldVersions
incmdconfig.go
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
pkg/hhfab/cmdversions.go | New command implementation handling missing config and live fetch |
pkg/hhfab/cmdconfig.go | Remove deprecated Versions function |
cmd/hhfab/main.go | Add --live flag to the versions command |
.github/workflows/ci.yaml | Invoke bin/hhfab versions in multiple CI steps |
Comments suppressed due to low confidence (2)
pkg/hhfab/cmdversions.go:96
- Add unit tests for formatVersions and compareVersionMaps to verify correct YAML output in both override and no-override scenarios.
func formatVersions(releaseVersions, overriddenVersions fabapi.Versions) (string, error) {
pkg/hhfab/cmdversions.go:21
- [nitpick] Add a Go doc comment for the exported Versions function explaining its parameters and behavior (missing config vs live cluster).
func Versions(ctx context.Context, workDir, cacheDir string, hMode HydrateMode, live bool) error {
@Frostman , I'm dropping the
|
fc41208
to
347df1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
347df1b
to
b0b88c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
When no fab.yaml is found, the versions command shows the release versions instead of an error:
VS: