Revert "fix(view): AuthorBarChart에서 Author 10명 넘어가는 경우 나머지는 others로 처리" #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Jul 23, 2024
bbanderson
approved these changes
Jul 23, 2024
| ); | ||
| console.log("reducedOtherAuthors", reducedOtherAuthors); | ||
| data = [...topAuthors, reducedOtherAuthors]; | ||
| data = data.slice(0, 10); |
There was a problem hiding this comment.
고생많으셨습니다!!👍👍👍
추후에 변수명을 data보다 더 자세히 지어봐도 좋을 것 같네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
잘못 올라간 커밋 취소하기 위한 pr 입니다...! 승인 해주시면 수정 후 다시 pr 하도록 하겠습니다!
Reverts #548