fix(view): Vertical Cluster List 에서 중복된 사용자는 추가시키지 않는것으로 수정 (#524) #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIITMEMARIO
changed the title
seungineer
approved these changes
Aug 2, 2024
ytaek
approved these changes
Aug 3, 2024
Comment on lines
+23
to
+37
| return authorArray.map((authorName: string) => { | ||
| // 이미 추가된 사용자인지 확인 후 추가되지 않은 경우에만 추가하고 Set에 이름을 저장 | ||
| if (!addedAuthors.has(authorName)) { | ||
| addedAuthors.add(authorName); | ||
| return ( | ||
| <Author | ||
| key={authorName} | ||
| name={authorName} | ||
| src={authSrcMap[authorName]} | ||
| /> | ||
| ); | ||
| } | ||
| // 이미 추가된 사용자인 경우 null 반환 | ||
| return null; | ||
| }); |
There was a problem hiding this comment.
위 방식도 좋은데, 중첩된 map 들이 많아서 복잡도가 조금 올라가는 느낌이 들긴 합니다.
- 어차피 set에 이미 있는 애들을 add해도 괜찮으니, if 문 하나는 줄일 수 있을 것 같고,
- return 하기 전에 addedAuthors를 만들어 놓고, render return 부분에는 rendering만 해주는게 좀 코드가 깔끔할 것 같습니다.
추후에 리팩토링 해서 다시 올려주셔도 좋을 것 같아요!
(다른 의견들도 환영합니다!!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#524
Result
사용자가 10명 이상 선택되었을때 +more로 표시 되던 로직을 삭제하고 중복 사용자를 제거하는 로직을 추가 하였습니다.
Work list
Discussion
#585 충돌로 인해 다시 pr 올립니다ㅠ...