Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mui/icons로 모든 아이콘 교체 #611

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

pcwadarong
Copy link
Member

@pcwadarong pcwadarong commented Aug 6, 2024

Related issue

#608

Result

기존

image

업데이트

image

Work list

  • svg를 삭제하고 material ui로 교체하였습니다.
  • react-icons를 적용하고 있는 refresh button과 content 폴더의 drop down을 교체하고 라이브러리를 제거하였습니다.
  • drop up(?) 버튼은 drop down 화살표를 rotate 하는 방향으로 하여 삭제하였습니다.
    • material icon에 위 아래 화살표가 다 있는 게 없기도 하고, 이미 show라는 클래스가 있었기 때문에 속성만 하나 더 추가하였습니다.

Discussion

추가로 아이콘을 바꾸고 싶다면, material ui 에서 rounded로 체크한 뒤 바꿀 수 있습니다.

@pcwadarong pcwadarong self-assigned this Aug 6, 2024
@pcwadarong pcwadarong requested review from a team as code owners August 6, 2024 15:42
Copy link
Member

@yuiseo yuiseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@bbanderson bbanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기대되네요👍👍👍

@pcwadarong pcwadarong merged commit 76d1934 into githru:main Aug 6, 2024
2 checks passed
@pcwadarong pcwadarong deleted the mui/icons branch August 6, 2024 15:53
@ytaek ytaek added this to the v0.7.0 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants