Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO COMMIT 페이지 UI 개선 #613

Merged
merged 4 commits into from
Aug 7, 2024
Merged

NO COMMIT 페이지 UI 개선 #613

merged 4 commits into from
Aug 7, 2024

Conversation

pcwadarong
Copy link
Member

@pcwadarong pcwadarong commented Aug 6, 2024 •
edited
Loading

Related issue

close #584

Result

기존
image

수정
image
image

Work list

  • 기존 NO COMMIT EXISTS 만 나오던 화면에 흑백으로 변환한 로고와 멘트를 함께 넣었습니다.
  • 보여줄 게 없음에도 불구하고 하단 스크롤이 생기던 문제를, 커밋 내역이 있어 스크롤 해야 할 때와 없을 때로 나눠서 스타일링을 주도록 해결하였습니다.
  • 혹시 화이트 모드를 구현할 것을 대비하여 svg에는 불투명도를 줘서 두 모드에 모두 어울리게 하였습니다.

Else

ci와 package.json는 제 브런치가 꼬여서 함께 수정된 것으로 올라가긴 했는데, 이미 이전에 PR 했던 내용입니다!

@pcwadarong pcwadarong requested review from a team as code owners August 6, 2024 17:26
@pcwadarong pcwadarong self-assigned this Aug 6, 2024
bbanderson
bbanderson approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@bbanderson bbanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와... 둥글둥글 부드럽고 최고네요!!👍

packages/view/src/assets/monoLogo.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW🤩

lxxmnmn
lxxmnmn reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@lxxmnmn lxxmnmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 너무 예쁩니다 🤩👏👏✨

kimdaeyeobbb
kimdaeyeobbb approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@kimdaeyeobbb kimdaeyeobbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조화로우면서도 느낌있는 화면 잘 구사해주셨네요 👏 👏 👏

@HIITMEMARIO
Copy link
Contributor

와! 진짜 깔끔해졌네요...! 이쁩니다!!😃

@pcwadarong pcwadarong merged commit 5a5a6e4 into githru:main Aug 7, 2024
2 checks passed
@pcwadarong
Copy link
Member Author

@bbanderson @kimdaeyeobbb @lxxmnmn @HIITMEMARIO 피드백 감사합니다 ㅎㅎ 머지하겠습니다!

@ytaek
Copy link
Contributor

ytaek commented Aug 7, 2024

우와 grayscale 로고를 활용하는 이거 센스네요!!!
캬아아아아앙아아아아아아아아

@ytaek
Copy link
Contributor

ytaek commented Aug 7, 2024

ci와 package.json는 제 브런치가 꼬여서 함께 수정된 것으로 올라가긴 했는데, 이미 이전에 PR 했던 내용입니다!

요거 아마 계속 발생할 수도 있습니다.
origin에서 새롭게 branch를 따서 작업한 뒤에 (git switch -C dev) main으로 merge 한뒤에 push해보시던지
이리저리 해도 안되면 그냥 간단(?)하게 origin 폭파 시킨 다음에 다시 fork 해서 쓰는 방법도 있습니다

@pcwadarong
Copy link
Member Author

@ytaek 헉..그렇군요 깃헙 너무 어렵네요 .. 감사합니다 참고하겠습니다!!

@ytaek ytaek added this to the v0.7.0 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxxmnmn lxxmnmn lxxmnmn left review comments

@kimdaeyeobbb kimdaeyeobbb kimdaeyeobbb approved these changes

@bbanderson bbanderson bbanderson approved these changes

Assignees

@pcwadarong pcwadarong

Labels
✨ view
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

[view] 커밋이 하나도 없는 경우 화면 수정 논의
6 participants
@pcwadarong @HIITMEMARIO @ytaek @bbanderson @kimdaeyeobbb @lxxmnmn