Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Author to Avator + tooltip of material-ui #639

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

pcwadarong
Copy link
Member

@pcwadarong pcwadarong commented Aug 12, 2024

Related issue

close #638

Result

image

Work list

  • 하드코딩 되어 있는 @common/Author을 mui의 avator로 교체하였습니다.
  • 마찬가지로 hover할 시 뜨는 nickname을 tooltip을 이용하여 교체하였습니다.
  • 필요 없어진 scss 파일은 삭제하였습니다.

@pcwadarong pcwadarong self-assigned this Aug 12, 2024
@pcwadarong pcwadarong requested review from a team as code owners August 12, 2024 13:59
@pcwadarong pcwadarong changed the title Convert Author to Avator + tooltips of material-ui Convert Author to Avator + tooltip of material-ui Aug 12, 2024
@seungineer
Copy link
Member

이렇게 하나하나 바꿔가며 mui를 도입할 수 있겠군요!
배워갑니다 👍👍 👍 👍
🔥 LGTM 🔥

@pcwadarong
Copy link
Member Author

pcwadarong commented Aug 12, 2024

@seungineer 맞습니다! 혹시 작업하시다가 어? 이거 직접 만들지 않고 바꾸면 좋겠는데.. 하는 거 있으면 말씀해주세요!! ㅎㅎㅎ 감사합니다🔥

Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGGGGTM!!!
짧아서 더 좋네요 :)

@pcwadarong pcwadarong merged commit 6ee915d into githru:main Aug 12, 2024
2 checks passed
@ytaek ytaek added this to the v0.7.0 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avator, Tool tips
3 participants