Theme Picker UI Update #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxxjinn
reviewed
Sep 5, 2024
There was a problem hiding this comment.
(궁금) 단위를 rem이랑 px 섞어서 쓰신 이유가 있으신가요??😮
There was a problem hiding this comment.
일단 딱딱 떨어지는 단위만 rem으로 쓰긴 했습니다..ㅎㅎ 그런데 이 부분에 대해 뷰팀 전체 회의가 필요할 것 같습니닷...저희가 추후 고치더라도 처음 개발할 때부터 rem이면 더 좋겠네요!
There was a problem hiding this comment.
https://yozm.wishket.com/magazine/detail/1410/
https://code.visualstudio.com/docs/editor/accessibility
크롬 브라우저를 예시로 들자면 사용자가 브라우저의 폰트 크기를 임의로 조정할 경우 따라서 조정되는 기능이 있습니다! vscode에서도 window.zoomlevel로 에디터가 아닌 프로그램 자체의 확대 축소 기능을 제공하는 걸로 알고 있는데요, 그런데 이게 확장 프로그램이 rem을 쓰냐 px을 쓰냐에 따라 줌인아웃에 영향을 주는지는 확신할 수는 없네요..! ㅎㅎ
xxxjinn
approved these changes
Sep 5, 2024
ytaek
approved these changes
Sep 5, 2024
| @@ -1622,7 +1622,7 @@ | |||
| "insertions": 40, | |||
| "deletions": 0 | |||
| }, | |||
| "packages/view/src/assets/styles/_pallete.scss": { | |||
| "packages/view/src/assets/styles/_pallette.scss": { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#698 #687
Result
as is
to be
Work list
Discussion