Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[view] branch fake asset 관련 이슈 #706

Merged
merged 6 commits into from
Sep 6, 2024
Merged

[view] branch fake asset 관련 이슈 #706

merged 6 commits into from
Sep 6, 2024

Conversation

xxxjinn
Copy link
Contributor

@xxxjinn xxxjinn commented Sep 5, 2024

Related issue

close #705

Result

image

Work list

fake-asset의 branch-list.json 내부 코드 구조를 바꿔서 로컬에서 branchList를 제대로 불러올 수 있도록 했습니다.

Discussion

@xxxjinn xxxjinn added this to the v0.7.2 milestone Sep 5, 2024
@xxxjinn xxxjinn self-assigned this Sep 5, 2024
@xxxjinn xxxjinn requested review from a team as code owners September 5, 2024 14:14
Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 수정 감사합니다!!!

Copy link
Contributor

@lxxmnmn lxxmnmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀

@xxxjinn xxxjinn merged commit 3eab981 into githru:main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[view] 로컬 환경에서 branchList가 나오지 않는 문제
3 participants