Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[view] 레이아웃이 잘리는 문제 해결 #731

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

pcwadarong
Copy link
Member

@pcwadarong pcwadarong commented Sep 23, 2024

Related issue

close #697 #719

Result

AS IS

image
image

TO BE

image
image

Work list

  • 복잡한 레이아웃이 아니기 때문에 grid에서 flex로 수정하였으며, 오른쪽 차트에 flex:1 을 주어 잘리지 않도록 하였습니다.
  • 이전 이슈 [view] 툴팁 교체 및 폴더 구조 그래프 명시성 확보 #720 에서 다뤘던 말 줄임 표시를 원복하였습니다.
  • 해당 이슈와는 크게 관련 없지만..! 사용하지 않는 + 다른 파일과 중복된 constant 파일이 있어 제거하였습니다.

@pcwadarong pcwadarong added this to the v0.7.2 milestone Sep 23, 2024
@pcwadarong pcwadarong self-assigned this Sep 23, 2024
@pcwadarong pcwadarong requested review from a team as code owners September 23, 2024 00:41
@@ -104,7 +104,7 @@ const Detail = ({ selectedData, clusterId, authSrcMap }: DetailProps) => {
title={id}
PopperProps={{ sx: { ".MuiTooltip-tooltip": { bgcolor: "#3c4048" } } }}
>
<p>{`${id.slice(0, 6)}...`}</p>
<p>{`${id.slice(0, 6)}`}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍👍👍❤️❤️

@@ -19,8 +19,7 @@ body {
}

.middle-container {
display: grid;
grid-template-columns: 4fr 2fr;
display: flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(궁금) pr 본문에 말씀하신 복잡한 레이아웃이란 무엇을 의미하는건가요??

Copy link
Contributor

@xxxjinn xxxjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM입니다!!🥰🥰

Copy link
Contributor

@joonwonBaek joonwonBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@pcwadarong pcwadarong merged commit 0bf737d into githru:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

클러스트 리스트 부분 레이아웃 수정
3 participants