Release v6.0.0 #4002
Merged
Release v6.0.0 #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to building test gems in a cache friendly way using: `GEM_VERSION=$(git describe --tags 2>/dev/null | sed 's/-/./g' | sed 's/v//') bundle exec rake build_gem`
lildude
commented
Jan 26, 2018
| @@ -2,7 +2,7 @@ require File.expand_path('../lib/linguist/version', __FILE__) | |||
|
|
|||
| Gem::Specification.new do |s| | |||
| s.name = 'github-linguist' | |||
| s.version = Linguist::VERSION | |||
| s.version = ENV['GEM_VERSION'] || Linguist::VERSION | |||
There was a problem hiding this comment.
Added this to make it easy to build test gems with version numbers that don't cause caching problems using:
GEM_VERSION=$(git describe --tags 2>/dev/null | sed 's/-/./g' | sed 's/v//') bundle exec rake build_gem
... which gives us cache-friendly names like: github-linguist-5.3.3.50.g6186660e.gem
dbussink
approved these changes
Jan 26, 2018
This was referenced Jan 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's finally here folks, v6.0.0 with all of these changes:
... and an update to all the latest grammars.