Skip to content

Fix path matching in getResourceType to handle relative paths #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronpowell merged 2 commits into from
Feb 10, 2026
+2 −2
Merged

Fix path matching in getResourceType to handle relative paths #691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20806d3
Initial plan
Copilot Feb 10, 2026
f62a764
Fix path matching in getResourceType to support relative paths
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/src/scripts/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,9 @@ export function getResourceType(filePath: string): string {
if (filePath.endsWith(".agent.md")) return "agent";
if (filePath.endsWith(".prompt.md")) return "prompt";
if (filePath.endsWith(".instructions.md")) return "instruction";
if (filePath.includes("/skills/") && filePath.endsWith("SKILL.md"))
if (/(^|\/)skills\//.test(filePath) && filePath.endsWith("SKILL.md"))
return "skill";
Comment on lines 229 to 233
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getResourceType() returns "instruction" for .instructions.md, but the VS Code install config (VSCODE_INSTALL_CONFIG) is keyed by "instructions". In openFileModal(), getVSCodeInstallUrl(type, ...) will therefore return null for instruction files, hiding the install dropdown in the modal for instructions opened from the list or via deep link. Consider normalizing the type names (e.g., use "instructions" everywhere) or adding an alias mapping in getVSCodeInstallUrl so both "instruction" and "instructions" resolve to the same config entry.

Copilot uses AI. Check for mistakes.
if (filePath.includes("/hooks/") && filePath.endsWith("README.md"))
if (/(^|\/)hooks\//.test(filePath) && filePath.endsWith("README.md"))
return "hook";
if (filePath.endsWith(".collection.yml")) return "collection";
return "unknown";
Expand Down
Loading