feat: respect CHANGES_REQUESTED approval state
#339
Merged
+299
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as `REVIEW_REQUIRED`
…es requested / reviews required and failing CI checks
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- tests/templates/test_deployment_message.md: Evaluated as low risk
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, this Action has not respected the
CHANGES_REQUESTEDreview state on pull request. This PR makes it so thatCHANGES_REQUESTEDwill be treated the same way asREVIEW_REQUIREDgoing forward. By doing so,.deployoperations will be blocked if your PR is currently in a state of requested changes.To think about this in another way... any pull request that is not in the
APPROVEDstate will be treated as "missing approvals".This is likely the desired state for nearly everyone using this Action, but has not been enforced in the past.