-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading github/codeql
dependency to 2.14.6
#411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ast-dataflow C++: Accept test changes.
This matches the v2.11.6 CodeQL CLI bundle.
The C/C++ extractor now correctly outputs the correct string with which an array is being initialized.
Update STR31-C and STR32-C test results
In CodeQL CLI 2.14 it is not possible to include deprecation warnings in test files because the paths are absolute, and so are not portable between different systems. We avoid the deprecation warning for now by copying the relevant parts of the dataflow library and removing the deprecation warning. This workaround can be removed when we upgrade to 2.15, as the deprecation warning has been fixed to not use absolute paths.
Also fix another deprecation warning issue.
rvermeulen
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will follow-up on the off by one in the string literal representation, because I couldn't find it in the change notes of our cpp library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the CodeQL CLI version to 2.14.6.
One notable change in this release is that the C++ AST dataflow library has been marked as deprecated. For the upgrade, I haven't attempted to switch to the new dataflow library, which would require a much closer evaluation of real world results.
Unfortunately, it is not possible to "accept" the new test results with the deprecation warning included, because the deprecation warning contains an absolute path, which causes results comparison failures in qltest. This is addressed in CodeQL CLI 2.15.0, but in the short term I have included a copy of the relevant dataflow libraries in this repository in order to remove the deprecation warning.
Change request type
.ql
,.qll
,.qls
or unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.