Fix maccatalyst RID detection in SDK targets#485
Merged
SteveSandersonMS merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
The OS detection logic falls through to 'linux' for maccatalyst-* RIDs since they don't start with 'win' or 'osx'. Add explicit handling for the 'maccatalyst' prefix to map it to 'osx', so the correct Darwin CLI binary is downloaded. Relates to #454 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where Mac Catalyst RIDs (maccatalyst-x64, maccatalyst-arm64) were incorrectly falling through to Linux in the .NET SDK's MSBuild targets, causing the wrong CLI binary to be downloaded. The fix adds explicit handling to map Mac Catalyst RIDs to osx during the OS detection phase.
Changes:
- Add maccatalyst RID detection in the OS determination logic, mapping it to
osxto align with runtime behavior whereOperatingSystem.IsMacOS()returns true for Mac Catalyst apps
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OS detection logic in \GitHub.Copilot.SDK.targets\ falls through to \linux\ for \maccatalyst-*\ RIDs since they don't start with \win\ or \osx. This means passing -r maccatalyst-x64\ or -r maccatalyst-arm64\ downloads the Linux CLI binary instead of the Darwin one.
This adds explicit handling for the \maccatalyst\ prefix to map it to \osx, so _CopilotRid\ resolves to \osx-x64\ / \osx-arm64\ and the correct Darwin CLI binary is downloaded.
Relates to #454, improves on #467 which added _CopilotPlatform\ mappings but missed the upstream OS detection.