Skip to content

Conversation

BaseMax
Copy link

@BaseMax BaseMax commented May 13, 2025

Fix typo from commited to committed

@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 19:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes typos in the code comments and error messages by correcting "commited" to "committed."

  • Updated a comment in the raft test file.
  • Corrected a comment in the Raft source file.
  • Fixed two error message strings in the inflight test file.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
internal/raft/raft_test.go Updated typo in a comment regarding snapshots.
internal/raft/raft.go Corrected typo in a comment about snapshots.
internal/raft/inflight_test.go Fixed typos in error messages in tests.
Comments suppressed due to low confidence (1)

internal/raft/raft_test.go:1392

  • Typo detected: replace 'commited' with 'committed' in the comment.
// with nothing commited, asking for a snapshot should return an error


// ErrNothingNewToSnapshot is returned when trying to create a snapshot
// but there's nothing new commited to the FSM since we started.
// but there's nothing new committed to the FSM since we started.
Copy link
Preview

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix confirmed: the correction from 'commited' to 'committed' is correct.

Copilot uses AI. Check for mistakes.

in.Commit(1)
if in.Committed().Len() != 0 {
t.Fatalf("should not be commited")
t.Fatalf("should not be committed")
Copy link
Preview

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo corrected: ensure 'commited' is replaced with 'committed' in the error message.

Copilot uses AI. Check for mistakes.

in.Commit(1)
if in.Committed().Len() != 1 {
t.Fatalf("should be commited")
t.Fatalf("should be committed")
Copy link
Preview

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo corrected: ensure 'commited' is replaced with 'committed' in the error message.

Copilot uses AI. Check for mistakes.

@BaseMax
Copy link
Author

BaseMax commented Aug 31, 2025

cc @meiji163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant