-
Notifications
You must be signed in to change notification settings - Fork 11
feat(proxy): add token-based rate limiting via response parsing #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mossaka
wants to merge
8
commits into
main
Choose a base branch
from
feat/token-rate-limiting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+994
−51
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9d19f3a
feat(api-proxy): add token extractor PassThrough stream
Mossaka 994080a
feat(api-proxy): add token-per-minute rate limiting and CLI support
Mossaka c210cbc
feat(api-proxy): integrate token extractor into proxy response pipeline
Mossaka fef17a6
test: add integration tests for token rate limiting
Mossaka 169a71c
fix: make integration tests robust against Docker build output in stdout
Mossaka 5031a49
fix: use single-quoted bash -c and escaped JSON in rate limit tests
Mossaka ce04391
fix: avoid curl -D /dev/stdout in rate limit tests (exit code 23)
Mossaka 20aa696
fix(deps): patch minimatch ReDoS vulnerability and add TPM coverage t…
Mossaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check()can now returnlimitType: 'tpm'. The API proxy’s 429 builder incontainers/api-proxy/server.jscurrently only maps rpm/rph/bytes_pm for the human label andwindowfield, so a TPM rejection will produce a confusing label and an incorrectwindowvalue (it will fall through to the bytes-per-minute case). Please update the server-side mapping to include 'tpm' (and a distinct window like per_minute_tokens) so clients can interpret the error correctly.