-
Notifications
You must be signed in to change notification settings - Fork 11
fix: prevent agent from accessing host git credentials #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+204
−4
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |||||||
| * Security Threat Model: | ||||||||
| * - AI agents can be manipulated through prompt injection attacks | ||||||||
| * - Attackers inject commands to read credential files using bash tools (cat, base64, curl) | ||||||||
| * - Credentials at risk: Docker Hub, GitHub CLI, NPM, Cargo, Composer tokens | ||||||||
| * - Credentials at risk: Docker Hub, GitHub CLI, NPM, Cargo, Composer tokens, Git credentials/extraheaders | ||||||||
| * | ||||||||
| * Security Mitigation: | ||||||||
| * - Selective mounting: Only mount directories needed for operation | ||||||||
|
|
@@ -342,8 +342,164 @@ describe('Credential Hiding Security', () => { | |||||||
| }, 120000); | ||||||||
| }); | ||||||||
|
|
||||||||
| describe('Git Credential Hiding', () => { | ||||||||
| test('Test 15: Git XDG config is hidden (empty file)', async () => { | ||||||||
| const homeDir = os.homedir(); | ||||||||
| const gitConfig = `${homeDir}/.config/git/config`; | ||||||||
|
|
||||||||
| const result = await runner.runWithSudo( | ||||||||
| `cat ${gitConfig} 2>&1 | grep -v "^\\[" | head -1`, | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| expect(result).toSucceed(); | ||||||||
| // Output should be empty (no credential data leaked) | ||||||||
| const output = result.stdout.trim(); | ||||||||
| expect(output).toBe(''); | ||||||||
| }, 120000); | ||||||||
|
|
||||||||
| test('Test 16: Git XDG credentials store is hidden (empty file)', async () => { | ||||||||
| const homeDir = os.homedir(); | ||||||||
| const gitCredentials = `${homeDir}/.config/git/credentials`; | ||||||||
|
|
||||||||
| const result = await runner.runWithSudo( | ||||||||
| `cat ${gitCredentials} 2>&1 | grep -v "^\\[" | head -1`, | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| expect(result).toSucceed(); | ||||||||
| // Output should be empty (no plaintext tokens leaked) | ||||||||
| const output = result.stdout.trim(); | ||||||||
| expect(output).not.toContain('https://'); | ||||||||
| expect(output).not.toContain('github.com'); | ||||||||
| }, 120000); | ||||||||
|
|
||||||||
| test('Test 17: .gitconfig is hidden (empty file)', async () => { | ||||||||
| const homeDir = os.homedir(); | ||||||||
| const gitconfig = `${homeDir}/.gitconfig`; | ||||||||
|
|
||||||||
| const result = await runner.runWithSudo( | ||||||||
| `cat ${gitconfig} 2>&1 | grep -v "^\\[" | head -1`, | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| expect(result).toSucceed(); | ||||||||
| const output = result.stdout.trim(); | ||||||||
| // Should not contain credential helpers or extraheader tokens | ||||||||
| expect(output).not.toContain('credential'); | ||||||||
| expect(output).not.toContain('extraheader'); | ||||||||
| expect(output).not.toContain('AUTHORIZATION'); | ||||||||
| }, 120000); | ||||||||
|
|
||||||||
| test('Test 18: .git-credentials is hidden (empty file)', async () => { | ||||||||
| const homeDir = os.homedir(); | ||||||||
| const gitCredentials = `${homeDir}/.git-credentials`; | ||||||||
|
|
||||||||
| const result = await runner.runWithSudo( | ||||||||
| `cat ${gitCredentials} 2>&1 | grep -v "^\\[" | head -1`, | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| expect(result).toSucceed(); | ||||||||
| const output = result.stdout.trim(); | ||||||||
| // Should not contain plaintext tokens | ||||||||
| expect(output).not.toContain('https://'); | ||||||||
| expect(output).not.toContain('github.com'); | ||||||||
| }, 120000); | ||||||||
|
|
||||||||
| test('Test 19: Workspace .git/config has no extraheader tokens', async () => { | ||||||||
| // Create a temporary git repo with a fake extraheader to test sanitization | ||||||||
| const result = await runner.runWithSudo( | ||||||||
| `sh -c 'cd /tmp && rm -rf awf-git-test && mkdir awf-git-test && cd awf-git-test && git init && git config --local http.https://github.com/.extraheader "AUTHORIZATION: basic dGVzdDp0b2tlbg==" && cat .git/config' 2>&1 | grep -v "^\\["`, | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| // The entrypoint sanitizes AWF_WORKDIR, but this is a separate temp dir | ||||||||
| // so it won't be sanitized. This test verifies the git config output format. | ||||||||
| // The critical test is that the AWF_WORKDIR workspace is sanitized. | ||||||||
| expect(result).toSucceed(); | ||||||||
| }, 120000); | ||||||||
|
Comment on lines
+426
to
+441
|
||||||||
|
|
||||||||
| test('Test 20: git credential fill returns empty for github.com', async () => { | ||||||||
| // Verify that git credential helpers are disabled and cannot provide tokens | ||||||||
| const result = await runner.runWithSudo( | ||||||||
| `sh -c 'echo "protocol=https | ||||||||
| host=github.com" | git credential fill 2>&1' | grep -v "^\\[" | head -5`, | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| // Should not contain any password/token | ||||||||
| const output = result.stdout.trim(); | ||||||||
| expect(output).not.toContain('password=ghp_'); | ||||||||
| expect(output).not.toContain('password=gho_'); | ||||||||
| expect(output).not.toContain('password=github_pat_'); | ||||||||
| }, 120000); | ||||||||
|
|
||||||||
| test('Test 21: Chroot mode hides git credentials at /host paths', async () => { | ||||||||
| const homeDir = os.homedir(); | ||||||||
|
|
||||||||
| // Try to read git config at /host path | ||||||||
| const result = await runner.runWithSudo( | ||||||||
| `cat /host${homeDir}/.config/git/credentials 2>&1 | grep -v "^\\[" | head -1`, | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| // May succeed with empty content or fail with "No such file" (both indicate hiding) | ||||||||
| if (result.success) { | ||||||||
| const output = result.stdout.trim(); | ||||||||
| expect(output).not.toContain('https://'); | ||||||||
| expect(output).not.toContain('github.com'); | ||||||||
| } else { | ||||||||
| expect(result.stderr).toMatch(/No such file|cannot access/i); | ||||||||
| } | ||||||||
| }, 120000); | ||||||||
|
|
||||||||
| test('Test 22: Debug logs show git credential sanitization', async () => { | ||||||||
| const result = await runner.runWithSudo( | ||||||||
| 'echo "test"', | ||||||||
| { | ||||||||
| allowDomains: ['github.com'], | ||||||||
| logLevel: 'debug', | ||||||||
| timeout: 60000, | ||||||||
| } | ||||||||
| ); | ||||||||
|
|
||||||||
| expect(result).toSucceed(); | ||||||||
| // Check that entrypoint logs show git credential sanitization | ||||||||
| expect(result.stderr).toMatch(/Sanitizing git credentials/i); | ||||||||
|
||||||||
| expect(result.stderr).toMatch(/Sanitizing git credentials/i); | |
| const allOutput = `${result.stdout}\n${result.stderr}`; | |
| expect(allOutput).toMatch(/Sanitizing git credentials/i); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workspace git config sanitization relies on AWF_WORKDIR pointing to the workspace directory. However, AWF_WORKDIR defaults to the user's home directory when --container-workdir is not specified (see docker-manager.ts:471). This means when running locally without --container-workdir, if the current directory is not the home directory, the sanitization will target the wrong .git/config file.
For example, if running from /home/user/myrepo without --container-workdir:
Consider either: