Add ecosystem domains for clojure, elixir, kotlin, scala, zig #17072
+32
−8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -154,6 +154,14 @@ var runtimeToEcosystem = map[string]string{ | |||||
| "bun": "node", // bun.sh is in the node ecosystem | ||||||
| "deno": "node", // deno.land is in the node ecosystem | ||||||
| "uv": "python", // uv is a Python package manager | ||||||
| "clojure": "clojure", | ||||||
| "dart": "dart", | ||||||
| "elixir": "elixir", | ||||||
| "kotlin": "kotlin", | ||||||
| "php": "php", | ||||||
|
Contributor
There was a problem hiding this comment. Nice addition of new runtime-to-ecosystem mappings. The |
||||||
| "scala": "scala", | ||||||
| "swift": "swift", | ||||||
| "zig": "zig", | ||||||
| } | ||||||
|
|
||||||
| // getDomainsFromRuntimes extracts ecosystem domains based on the specified runtimes | ||||||
|
|
@@ -226,14 +234,17 @@ func getDomainsFromRuntimes(runtimes map[string]any) []string { | |||||
| // | ||||||
| // # Supported ecosystem identifiers: | ||||||
| // - "defaults": basic infrastructure (certs, JSON schema, Ubuntu, package mirrors) | ||||||
| // - "clojure": Clojure/Clojars | ||||||
| // - "containers": container registries (Docker, GHCR, etc.) | ||||||
| // - "dart": Dart/Flutter ecosystem | ||||||
| // - "dotnet": .NET and NuGet ecosystem | ||||||
| // - "elixir": Elixir/Hex | ||||||
| // - "github": GitHub domains (*.githubusercontent.com, github.githubassets.com, etc.) | ||||||
| // - "github-actions": GitHub Actions blob storage domains | ||||||
| // - "go": Go ecosystem | ||||||
| // - "haskell": Haskell ecosystem | ||||||
| // - "java": Java/Maven/Gradle | ||||||
| // - "kotlin": Kotlin/JetBrains | ||||||
| // - "linux-distros": Linux distribution package repositories | ||||||
| // - "node": Node.js/NPM/Yarn | ||||||
| // - "perl": Perl/CPAN | ||||||
|
|
@@ -242,8 +253,10 @@ func getDomainsFromRuntimes(runtimes map[string]any) []string { | |||||
| // - "python": Python/PyPI/Conda | ||||||
| // - "ruby": Ruby/RubyGems | ||||||
| // - "rust": Rust/Cargo/Crates | ||||||
| // - "scala": Scala/SBT | ||||||
| // - "swift": Swift/CocoaPods | ||||||
| // - "terraform": HashiCorp/Terraform | ||||||
| // - "zig": Zig | ||||||
| func GetAllowedDomains(network *NetworkPermissions) []string { | ||||||
| if network == nil { | ||||||
| domainsLog.Print("No network permissions specified, using defaults") | ||||||
|
|
@@ -295,25 +308,30 @@ func GetAllowedDomains(network *NetworkPermissions) []string { | |||||
| var ecosystemPriority = []string{ | ||||||
| "node-cdns", // before "node" — more specific CDN sub-ecosystem | ||||||
| "rust", // before "python" — crates.io/index.crates.io/static.crates.io are native Rust domains | ||||||
| "clojure", | ||||||
| "containers", | ||||||
| "dart", | ||||||
|
There was a problem hiding this comment. The dart ecosystem shares the domain storage.googleapis.com with the go ecosystem. Since dart is positioned before go in the ecosystemPriority list, GetDomainEcosystem will resolve storage.googleapis.com to dart rather than go. Consider adding an inline comment similar to the existing rust/python comment (line 310) to document this intentional ordering decision and help future maintainers understand why dart must be positioned before go.
Suggested change
|
||||||
| "defaults", | ||||||
| "dotnet", | ||||||
| "elixir", | ||||||
| "fonts", | ||||||
| "github", | ||||||
| "github-actions", | ||||||
| "go", | ||||||
| "haskell", | ||||||
| "java", | ||||||
| "kotlin", | ||||||
| "linux-distros", | ||||||
| "node", | ||||||
| "perl", | ||||||
| "php", | ||||||
| "playwright", | ||||||
| "python", | ||||||
| "ruby", | ||||||
| "scala", | ||||||
| "swift", | ||||||
| "terraform", | ||||||
| "zig", | ||||||
| } | ||||||
|
|
||||||
| // GetDomainEcosystem returns the ecosystem identifier for a given domain, or empty string if not found. | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -852,11 +852,11 @@ func TestGetDomainsFromRuntimes(t *testing.T) { | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| expectEmpty: true, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| name: "elixir runtime adds elixir ecosystem domains", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| runtimes: map[string]any{ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "elixir": map[string]any{"version": "1.15"}, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| expectContains: []string{"hex.pm", "repo.hex.pm"}, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. The TestGetDomainsFromRuntimes test suite includes a test case for the elixir runtime mapping, but is missing test cases for the other newly added runtime mappings: clojure, kotlin, scala, zig, dart, php, and swift. Consider adding test cases for these runtimes to ensure their ecosystem mappings work correctly.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New
clojureecosystem entry looks good! Consider also addingclojars.orgmirrors or CDN domains if Clojure projects commonly fetch from them.