Add security architecture slide to slides/index.md#17501
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot use mermaid |
… slide Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in c46575f. Replaced the ASCII diagram with a Mermaid Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR adds a security architecture slide to the main slides deck (slides/index.md) that was previously only available in the comprehensive docs slides. The new slide features a Mermaid flowchart diagram illustrating the multi-layered defense architecture with isolated sandboxes and proxy/firewall controls.
Changes:
- Added a "Security Architecture" slide after "Security by Default" in
slides/index.mdwith a Mermaid diagram and three security principle bullets - Added Mermaid script initialization to enable diagram rendering in the slides
- Added four new workflow entries to the agent factory status documentation table
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| slides/index.md | Added security architecture slide with Mermaid diagram showing multi-layered defense and initialized Mermaid rendering script |
| docs/src/content/docs/agent-factory-status.mdx | Added four new workflow entries (Daily Rendering Scripts Verifier, Smoke Agent, Smoke Copilot ARM64, Smoke Multi PR) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| end | ||
|
|
||
| Proxy1["Proxy / Firewall"] | ||
| Gateway["Gateway<br/>(mcpg)"] |
There was a problem hiding this comment.
The HTML <br/> tag in the Gateway label should use HTML entity encoding to match the pattern used in docs/slides/index.md (line 406). The tag should be encoded as <br/> instead of <br/> to ensure consistent rendering across different Marp processors and prevent potential HTML injection issues in the diagram.
| Gateway["Gateway<br/>(mcpg)"] | |
| Gateway["Gateway<br/>(mcpg)"] |
| @@ -132,10 +133,13 @@ These are experimental agentic workflows used by the GitHub Next team to learn, | |||
| | [Semantic Function Refactoring](https://github.com/github/gh-aw/blob/main/.github/workflows/semantic-function-refactor.md) | claude | [](https://github.com/github/gh-aw/actions/workflows/semantic-function-refactor.lock.yml) | - | - | | |||
| | [Sergo - Serena Go Expert](https://github.com/github/gh-aw/blob/main/.github/workflows/sergo.md) | claude | [](https://github.com/github/gh-aw/actions/workflows/sergo.lock.yml) | - | - | | |||
| | [Slide Deck Maintainer](https://github.com/github/gh-aw/blob/main/.github/workflows/slide-deck-maintainer.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/slide-deck-maintainer.lock.yml) | `0 16 * * 1-5` | - | | |||
| | [Smoke Agent](https://github.com/github/gh-aw/blob/main/.github/workflows/smoke-agent.md) | codex | [](https://github.com/github/gh-aw/actions/workflows/smoke-agent.lock.yml) | - | - | | |||
| | [Smoke Claude](https://github.com/github/gh-aw/blob/main/.github/workflows/smoke-claude.md) | claude | [](https://github.com/github/gh-aw/actions/workflows/smoke-claude.lock.yml) | - | - | | |||
| | [Smoke Codex](https://github.com/github/gh-aw/blob/main/.github/workflows/smoke-codex.md) | codex | [](https://github.com/github/gh-aw/actions/workflows/smoke-codex.lock.yml) | - | - | | |||
| | [Smoke Copilot](https://github.com/github/gh-aw/blob/main/.github/workflows/smoke-copilot.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/smoke-copilot.lock.yml) | - | - | | |||
| | [Smoke Copilot ARM64](https://github.com/github/gh-aw/blob/main/.github/workflows/smoke-copilot-arm.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/smoke-copilot-arm.lock.yml) | - | - | | |||
| | [Smoke Gemini](https://github.com/github/gh-aw/blob/main/.github/workflows/smoke-gemini.md) | gemini | [](https://github.com/github/gh-aw/actions/workflows/smoke-gemini.lock.yml) | - | - | | |||
| | [Smoke Multi PR](https://github.com/github/gh-aw/blob/main/.github/workflows/smoke-multi-pr.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/smoke-multi-pr.lock.yml) | - | - | | |||
There was a problem hiding this comment.
These workflow entries appear to be unrelated to the stated purpose of this PR, which is to add a security architecture slide to the main slides deck. The PR description mentions adding a security architecture slide and Mermaid script initialization, but does not mention updating the agent factory status table. Consider moving these changes to a separate PR to maintain a clear separation of concerns.
The main slides deck (
slides/index.md) lacked a security architecture slide, while the docs slides (docs/slides/index.md) already had comprehensive coverage.Changes
slides/index.md: Added a "Security Architecture" slide after "Security by Default", featuring:flowchart TBdiagram of the Action Job VM showing isolated sandboxes (Agent, MCP Server, Skill) with Proxy/Firewall layers and central MCP Gateway routingslides/index.mdto enable diagram rendering at runtimeWarning
Custom agent used: technical-doc-writer
AI technical documentation writer for GitHub Actions library using GitHub Docs voice
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.