Copilot/update parser log javascript by pelikhan · Pull Request #17605 · github/gh-aw

pelikhan · 2026-02-21T22:52:09Z

No description provided.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Updates the Gemini log parser to handle Gemini CLI JSONL (typed per-line JSON entries) and generate consistent markdown output via shared log parsing/rendering helpers.

Changes:

Refactors parse_gemini_log.cjs to parse Gemini JSONL, transform entries into the canonical schema, and reuse shared markdown generation helpers.
Adds transformGeminiEntries() to normalize Gemini-specific entry types (init/message/tool_use/tool_result) into the shared format.
Introduces a new Vitest suite covering parsing, delta merging, tool rendering, and stats extraction.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
actions/setup/js/parse_gemini_log.cjs	Reworks Gemini parser to ingest JSONL, normalize entries, and render markdown via shared helpers (conversation + info sections).
actions/setup/js/parse_gemini_log.test.cjs	Adds unit tests validating JSONL parsing behavior, tool formatting, delta merge behavior, and stats extraction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-21T22:54:54Z

actions/setup/js/parse_gemini_log.cjs

+        cache_read_input_tokens: stats.cached || 0,
+      },
+      duration_ms: stats.duration_ms || 0,
+      num_turns: stats.tool_calls || 0,


num_turns is being populated from stats.tool_calls, but generateInformationSection() renders num_turns as Turns. Tool call count is not the same as conversation turns, so this will produce misleading summaries. Consider omitting num_turns for Gemini (or mapping it from an actual turns field if Gemini provides one) and, if desired, render tool call count via an additionalInfoCallback instead.

Suggested change

num_turns: stats.tool_calls || 0,

Copilot · 2026-02-21T22:54:54Z

actions/setup/js/parse_gemini_log.cjs

+        },
+      });
+    } else if (raw.type === "tool_result") {
+      const output = typeof raw.output === "string" ? raw.output : JSON.stringify(raw.output || "");


When raw.output is not a string, JSON.stringify(raw.output || "") will incorrectly coerce valid falsy outputs like 0, false, or "" into "", and undefined becomes "\"\"". Use a nullish check (e.g., raw.output == null ? "" : JSON.stringify(raw.output)) so primitives are preserved and missing output stays empty.

Suggested change

const output = typeof raw.output === "string" ? raw.output : JSON.stringify(raw.output || "");

const output =

typeof raw.output === "string"

? raw.output

: raw.output == null

? ""

: JSON.stringify(raw.output);

github-actions · 2026-02-21T22:56:02Z

🧪 Smoke Temporary ID is now testing temporary ID functionality...

github-actions · 2026-02-21T22:56:05Z

🚀 Smoke Gemini MISSION COMPLETE! Gemini has spoken. ✨

Smoke test completed. Build failed. Reported results to PR #17605.

github-actions · 2026-02-21T22:56:05Z

🧪 Smoke Project is now testing project operations...

github-actions · 2026-02-21T22:56:07Z

📰 BREAKING: Smoke Copilot ARM64 is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-21T22:59:04Z

✅ Smoke Project completed successfully. All project operations validated.

github-actions · 2026-02-21T23:00:35Z

Smoke Test Results for Gemini:

GitHub MCP Testing: ✅ (fix(USE-001): add standardized error codes to all safe output handlers #17557, Copilot/update firewall access editors #17599)
File Writing Testing: ✅
Bash Tool Testing: ✅
Build gh-aw: ❌ (Build failed)

Overall Status: FAIL

✨ Smoke Gemini — Powered by Gemini

github-actions · 2026-02-21T23:02:07Z

🦾 ARM64 Smoke Test Results — §22265960089

Arch: aarch64 ✅ | Author: @pelikhan

Test
Architecture (aarch64)	✅
GitHub MCP (merged PRs: #17599, #17591)	✅
Safe Inputs GH CLI	✅
Serena MCP	❌ (not in toolset)
Playwright (github.com)	✅
File Write + Bash read-back	✅
Discussion Interaction (#17606)	✅
Build gh-aw on ARM64	✅
Discussion Creation	✅
Workflow Dispatch (haiku-printer)	✅
PR Review	✅

Overall: ⚠️ PARTIAL PASS (11/12)

📰 BREAKING: Report filed by Smoke Copilot ARM64

github-actions

Quick review from the ARM64 smoke test agent 🦾 — the refactoring of parseGeminiLog to use a two-pass JSONL approach (parse all entries first, then transform) is clean and aligns well with the shared generateConversationMarkdown pattern used by other engine parsers. Two minor positive observations left inline. LGTM overall.

📰 BREAKING: Report filed by Smoke Copilot ARM64

github-actions · 2026-02-21T23:02:08Z

actions/setup/js/parse_gemini_log.cjs

+  for (const line of logContent.split("\n")) {
    const trimmed = line.trim();
-    if (!trimmed) {
+    if (!trimmed || !trimmed.startsWith("{")) {


Nice defensive check — filtering lines that don't start with { avoids unnecessary JSON.parse attempts on non-object lines, which is a good micro-optimization for large log files. 👍

github-actions · 2026-02-21T23:02:09Z

actions/setup/js/parse_gemini_log.cjs

-    markdown += lastResponse + "\n\n";
+  if (rawEntries.length === 0) {
+    return {
+      markdown: "## 🤖 Gemini\n\nLog format not recognized as Gemini JSONL.\n\n",


Providing a friendly error message when the log format isn't recognized is a great UX touch. Makes debugging much easier when a user accidentally points this at a non-Gemini log file. ✨

github-actions · 2026-02-21T23:02:21Z

📰 VERDICT: Smoke Copilot ARM64 has concluded. All systems operational. This is a developing story. 🎤

pelikhan · 2026-02-21T23:05:18Z

@copilot configure Gemini to allow reading outside the workspace

See errors https://github.com/github/gh-aw/actions/runs/22265960083/job/64412439749#step:37:1

Copilot · 2026-02-21T23:05:25Z

@pelikhan I've opened a new pull request, #17612, to work on those changes. Once the pull request is ready, I'll request review from you.

github-actions · 2026-02-21T23:24:37Z

📰 BREAKING: Smoke Copilot ARM64 is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-21T23:24:38Z

🧪 Smoke Temporary ID is now testing temporary ID functionality...

github-actions · 2026-02-21T23:24:39Z

🚀 Smoke Gemini MISSION COMPLETE! Gemini has spoken. ✨

Smoke test failed due to Go version mismatch. Results posted to PR #17605.

github-actions · 2026-02-21T23:24:40Z

🧪 Smoke Project is now testing project operations...

github-actions · 2026-02-21T23:27:35Z

✅ Smoke Project completed successfully. All project operations validated.

github-actions · 2026-02-21T23:29:17Z

Smoke Test Results

GitHub MCP: ✅
File Writing: ✅
Bash Tool: ✅
Build gh-aw: ❌ (Go version mismatch: 1.23.12 < 1.25.0, update blocked)

Overall Status: FAIL

✨ Smoke Gemini — Powered by Gemini

github-actions · 2026-02-21T23:30:13Z

🦾 ARM64 Smoke Test §22266358873 — PASS ✅

Architecture: aarch64 | PR by: @pelikhan

Test
Architecture (aarch64)	✅
GitHub MCP	✅
Safe Inputs GH CLI	✅
Serena MCP	❌ (tools not provisioned)
Playwright (github.com)	✅
File Write + Bash	✅
Discussion Interaction	✅
Build gh-aw ARM64	✅
Discussion Creation	✅
Haiku Printer Dispatch	✅
PR Review	✅

Overall: PASS (10/11 — Serena not provisioned)

📰 BREAKING: Report filed by Smoke Copilot ARM64

github-actions

Reviewed from ARM64 (aarch64) 🦾 — PR refactors Gemini log parsing to use shared log_parser_shared.cjs helpers, reducing duplication and aligning output format with other engine parsers. The transformGeminiEntries pipeline cleanly maps Gemini JSONL types to the canonical format. Two inline comments left on the import expansion and delta-merging logic.

📰 BREAKING: Report filed by Smoke Copilot ARM64

github-actions · 2026-02-21T23:30:14Z

actions/setup/js/parse_gemini_log.cjs

 /// <reference types="@actions/github-script" />

-const { createEngineLogParser } = require("./log_parser_shared.cjs");
+const { createEngineLogParser, generateConversationMarkdown, generateInformationSection, formatInitializationSummary, formatToolUse } = require("./log_parser_shared.cjs");


Good refactoring — importing generateConversationMarkdown, generateInformationSection, formatInitializationSummary, and formatToolUse from the shared module eliminates duplicated formatting logic and ensures consistent output across all engine parsers.

github-actions · 2026-02-21T23:30:14Z

actions/setup/js/parse_gemini_log.cjs

+    logEntries,
    mcpFailures: [],
    maxTurnsHit: false,
  };


The streaming delta merging logic here correctly handles Gemini's chunked assistant messages. The guard on entry.message.content.length === 1 ensures only single-content entries are merged, preventing accidental data loss. Consider adding a comment clarifying why multi-content entries are excluded from merging.

github-actions · 2026-02-21T23:30:30Z

📰 VERDICT: Smoke Copilot ARM64 has concluded. All systems operational. This is a developing story. 🎤

…pe definitions - Fix 3 subjective language issues across 3 spec files: - engine-review-summary.md: remove 'production-ready' qualifier, replace 'Easy to understand and follow' with technical description - go-type-patterns.md: replace 'Easy refactoring' with factual description - serena-tools-quick-reference.md: replace '✓ Perfect' with '✓ Complete' - Add TypeScript Type Definitions section to dev.md Safe Outputs System documenting handler-factory.d.ts, safe-outputs.d.ts, safe-outputs-config.d.ts, and github-script.d.ts from PR #17605 - Bump dev.md version to 2.7 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot AI and others added 2 commits February 21, 2026 22:01

Initial plan

8b78d8a

Update parse_gemini_log.cjs to handle actual Gemini CLI JSONL log format

a3fe7a8

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 21, 2026 22:52

Copilot started reviewing on behalf of pelikhan February 21, 2026 22:52 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

pelikhan added the water label Feb 21, 2026

github-actions bot added the smoke-copilot-arm label Feb 21, 2026

github-actions bot reviewed Feb 21, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 21, 2026

Configure Gemini to allow reading /tmp/gh-aw/ outside workspace #17612

Merged

Configure Gemini to allow reading /tmp/gh-aw/ outside workspace (#17612)

61869d3

pelikhan added water and removed water smoke-copilot-arm labels Feb 21, 2026

github-actions bot mentioned this pull request Feb 21, 2026

Smoke Test: Copilot ARM64 - 22266358873 #17618

Closed

github-actions bot added the smoke-copilot-arm label Feb 21, 2026

github-actions bot reviewed Feb 21, 2026

View reviewed changes

pelikhan merged commit 898cf58 into main Feb 21, 2026
135 checks passed

pelikhan deleted the copilot/update-parser-log-javascript branch February 21, 2026 23:34

This was referenced Feb 22, 2026

[docs] Consolidate developer specs v2.7 - tone fixes and TypeScript type definitions #17625

Closed

[docs] Update documentation for features from 2026-02-22 #17647

Merged

Comments

Conversation

pelikhan commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

pelikhan commented Feb 21, 2026

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Smoke Test Results

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

github-actions bot commented Feb 21, 2026 •

edited

Loading

github-actions bot commented Feb 21, 2026 •

edited

Loading