-
Notifications
You must be signed in to change notification settings - Fork 240
feat(gemini): fix /tmp/ access and add neutral tool mapping for Gemini CLI settings #17642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -174,6 +174,12 @@ func (e *GeminiEngine) GetExecutionSteps(workflowData *WorkflowData, logFile str | |
|
|
||
| var steps []GitHubActionStep | ||
|
|
||
| // Write .gemini/settings.json with context.includeDirectories and tools.core. | ||
| // This step runs after the MCP gateway setup (which may have written mcpServers config) | ||
| // and merges the context/tools settings into any existing settings.json. | ||
| settingsStep := e.generateGeminiSettingsStep(workflowData) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The settings step is prepended before the execution step — this ordering is important since the execution step relies on the settings file being present. The comment clarifying the merge behavior is helpful for maintainability. 👍 |
||
| steps = append(steps, settingsStep) | ||
|
|
||
| // Build gemini CLI arguments based on configuration | ||
| var geminiArgs []string | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix! Moving from
.includeDirectoriesto.context.includeDirectoriescorrects the schema path that Gemini CLI actually reads. Also broadening from/tmp/gh-aw/to/tmp/ensures agents can access cache-memory and other temp directories. ✅