Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in nested remote import resolution where relative imports were incorrectly resolved relative to the top-level workflow's directory instead of their immediate parent file's directory.
Changes:
- Modified
import_processor.goto parse a newremoteOriginfrom the resolved path for each nested import, ensuring the correctBasePathis derived - Added a comprehensive regression test validating two-level nested imports resolve correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/parser/import_processor.go | Fixed nested remote origin propagation by calling parseRemoteOrigin(resolvedPath) instead of reusing parent's origin |
| pkg/parser/import_remote_nested_test.go | Added regression test for two-level nested imports to validate the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17620
Summary
nestedRemoteOriginwas reusing the parent'sremoteOrigin(with the wrongBasePath); it now callsparseRemoteOrigin(resolvedPath)to derive the correctBasePathfor each fileworkflows/workflow.md→shared/file1.md→file2.mdcorrectly resolves toworkflows/shared/file2.mdinstead ofworkflows/file2.md