-
Notifications
You must be signed in to change notification settings - Fork 253
fix: SHA-pin actions/setup in agentics-maintenance.yml generation #18378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d9c2da2
a41bd27
9a27785
b29c1b5
fd90936
4398aa9
066da37
faf78c6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -149,9 +149,12 @@ jobs: | |||||||||||||||
| `) | ||||||||||||||||
|
|
||||||||||||||||
| // Get the setup action reference (local or remote based on mode) | ||||||||||||||||
| // Pass nil for data since maintenance workflow doesn't have WorkflowData | ||||||||||||||||
| // In release mode without data, it will return tag-based reference | ||||||||||||||||
| setupActionRef := ResolveSetupActionReference(actionMode, version, actionTag, nil) | ||||||||||||||||
| // Use the first available WorkflowData's ActionResolver to enable SHA pinning | ||||||||||||||||
| var resolver ActionSHAResolver | ||||||||||||||||
| if len(workflowDataList) > 0 && workflowDataList[0].ActionResolver != nil { | ||||||||||||||||
| resolver = workflowDataList[0].ActionResolver | ||||||||||||||||
|
Comment on lines
+154
to
+155
|
||||||||||||||||
| if len(workflowDataList) > 0 && workflowDataList[0].ActionResolver != nil { | |
| resolver = workflowDataList[0].ActionResolver | |
| for _, wfData := range workflowDataList { | |
| if wfData != nil && wfData.ActionResolver != nil { | |
| resolver = wfData.ActionResolver | |
| break | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring examples use “# ”, but this function passes the selected tag (actionTag override or version) to formatActionReference, so the comment will be “# ” (not necessarily the compiler version). Updating the comment/examples would avoid misleading callers when actionTag differs from version.