Skip to content

Add ecosystem domains for R, Julia, OCaml, Bazel, Lua #18405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mossaka merged 2 commits into from
Feb 25, 2026
Merged

Add ecosystem domains for R, Julia, OCaml, Bazel, Lua #18405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23e8e17
Add ecosystem domains for R, Julia, OCaml, Bazel, Lua
Mossaka Feb 25, 2026
809e824
Add unit tests for bazel, julia, lua, ocaml, r ecosystem domains
Mossaka Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/workflow/data/ecosystem_domains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"oneocsp.microsoft.com",
"*.vsblob.vsassets.io"
],
"bazel": ["releases.bazel.build", "mirror.bazel.build", "bcr.bazel.build", "blog.bazel.build"],
"clojure": ["repo.clojars.org", "clojars.org"],
"dart": ["pub.dev", "pub.dartlang.org", "storage.googleapis.com"],
"fonts": ["fonts.googleapis.com", "fonts.gstatic.com"],
Expand All @@ -73,6 +74,7 @@
"terraform": ["releases.hashicorp.com", "apt.releases.hashicorp.com", "yum.releases.hashicorp.com", "registry.terraform.io"],
"haskell": ["haskell.org", "*.hackage.haskell.org", "get-ghcup.haskell.org", "downloads.haskell.org"],
"kotlin": ["ge.jetbrains.com", "packages.jetbrains.team", "kotlin.bintray.com"],
"julia": ["pkg.julialang.org", "julialang.org", "julialang-s3.julialang.org"],
"java": [
"www.java.com",
"jdk.java.net",
Expand Down Expand Up @@ -122,6 +124,7 @@
"download.opensuse.org",
"cdn.redhat.com"
],
"lua": ["luarocks.org", "www.luarocks.org"],
"node": [
"npmjs.org",
"npmjs.com",
Expand Down Expand Up @@ -151,6 +154,7 @@
"telemetry.vercel.com"
],
"node-cdns": ["cdn.jsdelivr.net", "data.jsdelivr.com", "code.jquery.com", "cdn.sheetjs.com"],
"ocaml": ["opam.ocaml.org", "ocaml.org", "erratique.ch"],
"perl": ["cpan.org", "www.cpan.org", "metacpan.org", "cpan.metacpan.org"],
"php": ["repo.packagist.org", "packagist.org", "getcomposer.org", "bitbucket.org"],
"playwright": ["playwright.download.prss.microsoft.com", "cdn.playwright.dev"],
Expand All @@ -171,6 +175,7 @@
"index.crates.io",
"static.crates.io"
],
"r": ["cloud.r-project.org", "cran.r-project.org", "cran.rstudio.com", "r-project.org"],
Comment on lines 58 to 178
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New ecosystem domain categories were added here, but there are no corresponding unit tests asserting that these identifiers expand correctly via GetAllowedDomains (existing tests only cover a subset of categories). Adding a small test case per new ecosystem (bazel/julia/lua/ocaml/r) would help catch JSON formatting mistakes and prevent regressions in domain expansion behavior.

Copilot uses AI. Check for mistakes.
"ruby": ["rubygems.org", "api.rubygems.org", "rubygems.pkg.github.com", "bundler.rubygems.org", "gems.rubyforge.org", "gems.rubyonrails.org", "index.rubygems.org", "cache.ruby-lang.org", "*.rvm.io"],
"rust": ["crates.io", "index.crates.io", "static.crates.io", "sh.rustup.rs", "static.rust-lang.org"],
"scala": ["repo.scala-sbt.org", "scala-ci.typesafe.com", "repo.typesafe.com", "jitpack.io", "dl.bintray.com"],
Expand Down
110 changes: 104 additions & 6 deletions pkg/workflow/ecosystem_domains_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,104 @@ func TestEcosystemDomainExpansion(t *testing.T) {
}
})

t.Run("bazel ecosystem includes Bazel registry and download domains", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"bazel"},
}
domains := GetAllowedDomains(permissions)

expectedDomains := []string{
"releases.bazel.build",
"mirror.bazel.build",
"bcr.bazel.build",
}

for _, expectedDomain := range expectedDomains {
found := slices.Contains(domains, expectedDomain)
if !found {
t.Errorf("Expected domain '%s' to be included in bazel ecosystem, but it was not found", expectedDomain)
}
}
})

t.Run("julia ecosystem includes Julia package registry domains", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"julia"},
}
domains := GetAllowedDomains(permissions)

expectedDomains := []string{
"pkg.julialang.org",
"julialang.org",
}

for _, expectedDomain := range expectedDomains {
found := slices.Contains(domains, expectedDomain)
if !found {
t.Errorf("Expected domain '%s' to be included in julia ecosystem, but it was not found", expectedDomain)
}
}
})

t.Run("lua ecosystem includes LuaRocks domains", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"lua"},
}
domains := GetAllowedDomains(permissions)

expectedDomains := []string{
"luarocks.org",
"www.luarocks.org",
}

for _, expectedDomain := range expectedDomains {
found := slices.Contains(domains, expectedDomain)
if !found {
t.Errorf("Expected domain '%s' to be included in lua ecosystem, but it was not found", expectedDomain)
}
}
})

t.Run("ocaml ecosystem includes opam domains", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"ocaml"},
}
domains := GetAllowedDomains(permissions)

expectedDomains := []string{
"opam.ocaml.org",
"ocaml.org",
"erratique.ch",
}

for _, expectedDomain := range expectedDomains {
found := slices.Contains(domains, expectedDomain)
if !found {
t.Errorf("Expected domain '%s' to be included in ocaml ecosystem, but it was not found", expectedDomain)
}
}
})

t.Run("r ecosystem includes CRAN domains", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"r"},
}
domains := GetAllowedDomains(permissions)

expectedDomains := []string{
"cloud.r-project.org",
"cran.r-project.org",
"cran.rstudio.com",
}

for _, expectedDomain := range expectedDomains {
found := slices.Contains(domains, expectedDomain)
if !found {
t.Errorf("Expected domain '%s' to be included in r ecosystem, but it was not found", expectedDomain)
}
}
})

t.Run("multiple ecosystems can be combined", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"defaults", "dotnet", "python", "example.com"},
Expand Down Expand Up @@ -290,9 +388,9 @@ func TestEcosystemDomainExpansion(t *testing.T) {
func TestAllEcosystemDomainFunctions(t *testing.T) {
// Test that all ecosystem categories return non-empty slices
ecosystemCategories := []string{
"defaults", "containers", "dotnet", "dart", "github", "go",
"terraform", "haskell", "java", "linux-distros", "node",
"perl", "php", "playwright", "python", "ruby", "rust", "swift",
"defaults", "containers", "bazel", "dotnet", "dart", "github", "go",
"terraform", "haskell", "java", "julia", "linux-distros", "lua", "node",
"ocaml", "perl", "php", "playwright", "python", "r", "ruby", "rust", "swift",
}

for _, category := range ecosystemCategories {
Expand All @@ -315,9 +413,9 @@ func TestAllEcosystemDomainFunctions(t *testing.T) {
func TestEcosystemDomainsUniqueness(t *testing.T) {
// Test that each ecosystem category returns unique domains (no duplicates)
ecosystemCategories := []string{
"defaults", "containers", "dotnet", "dart", "github", "go",
"terraform", "haskell", "java", "linux-distros", "node",
"perl", "php", "playwright", "python", "ruby", "rust", "swift",
"defaults", "containers", "bazel", "dotnet", "dart", "github", "go",
"terraform", "haskell", "java", "julia", "linux-distros", "lua", "node",
"ocaml", "perl", "php", "playwright", "python", "r", "ruby", "rust", "swift",
}

for _, category := range ecosystemCategories {
Expand Down
Loading