Skip to content

[code-simplifier] refactor: simplify id-token permission handling with switch statement #18741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
+12 −5
Closed

[code-simplifier] refactor: simplify id-token permission handling with switch statement #18741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27a99b8
refactor: simplify id-token permission handling with switch statement
Feb 27, 2026
9080ee8
ci: trigger CI checks
github-actions[bot] Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions pkg/workflow/safe_outputs_permissions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,21 @@ func ComputePermissionsForSafeOutputs(safeOutputs *SafeOutputsConfig) *Permissio
// Handle id-token permission for OIDC/secret vault actions in user-provided steps.
// Explicit "none" disables auto-detection; explicit "write" always adds it;
// otherwise auto-detect from the steps list.
if safeOutputs.IDToken != nil && *safeOutputs.IDToken == "none" {
idToken := ""
if safeOutputs.IDToken != nil {
idToken = *safeOutputs.IDToken
}
switch idToken {
case "none":
safeOutputsPermissionsLog.Print("id-token permission explicitly disabled (none)")
} else if safeOutputs.IDToken != nil && *safeOutputs.IDToken == "write" {
case "write":
safeOutputsPermissionsLog.Print("id-token: write explicitly requested")
permissions.Set(PermissionIdToken, PermissionWrite)
} else if stepsRequireIDToken(safeOutputs.Steps) {
safeOutputsPermissionsLog.Print("Auto-detected OIDC/vault action in steps; adding id-token: write")
permissions.Set(PermissionIdToken, PermissionWrite)
default:
if stepsRequireIDToken(safeOutputs.Steps) {
safeOutputsPermissionsLog.Print("Auto-detected OIDC/vault action in steps; adding id-token: write")
permissions.Set(PermissionIdToken, PermissionWrite)
}
}

safeOutputsPermissionsLog.Printf("Computed permissions with %d scopes", len(permissions.permissions))
Expand Down
Loading