Skip to content

Add required "type": "http" field to safe-inputs MCP configuration #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Dec 7, 2025
Merged

Add required "type": "http" field to safe-inputs MCP configuration #5729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4cfad3
Initial plan
Copilot Dec 7, 2025
a3d14e6
Fix safe-inputs MCP server missing type field for Claude
Copilot Dec 7, 2025
1e62ee4
Update safe-inputs HTTP tests for health endpoint without auth
Copilot Dec 7, 2025
8e07b75
Add changeset for PR #5729 [skip-ci]
github-actions[bot] Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/patch-auto-generated-pr-5729.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/dev.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/release.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions pkg/workflow/safe_inputs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
}

safeInputs, exists := frontmatter["safe-inputs"]
if !exists {

Check failure on line 182 in pkg/workflow/safe_inputs.go

View workflow job for this annotation

GitHub Actions / lint 

empty-block: this block is empty, you can remove it (revive)
return nil
}

Expand Down Expand Up @@ -543,10 +543,8 @@
// Use HTTP transport configuration
yaml.WriteString(" \"" + constants.SafeInputsMCPServerID + "\": {\n")

// Add type field for HTTP
if includeCopilotFields {
yaml.WriteString(" \"type\": \"http\",\n")
}
// Add type field for HTTP (required by MCP specification for HTTP transport)
yaml.WriteString(" \"type\": \"http\",\n")

// HTTP URL using environment variable
if includeCopilotFields {
Expand Down Expand Up @@ -746,7 +744,7 @@
func GenerateSafeInputShellToolScriptForInspector(toolConfig *SafeInputToolConfig) string {
return generateSafeInputShellToolScript(toolConfig)
}

Check failure on line 747 in pkg/workflow/safe_inputs.go

View workflow job for this annotation

GitHub Actions / lint 

empty-block: this block is empty, you can remove it (revive)
// GenerateSafeInputPythonToolScriptForInspector generates a Python script tool handler
// This is a public wrapper for use by the CLI inspector command
func GenerateSafeInputPythonToolScriptForInspector(toolConfig *SafeInputToolConfig) string {
Expand Down
9 changes: 4 additions & 5 deletions pkg/workflow/safe_inputs_http_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ Test safe-inputs HTTP server
}
}

// Verify health check
// Verify health check (health endpoint doesn't require auth)
healthCheckItems := []string{
"curl -s -f -H \"Authorization: Bearer",
"curl -s -f http://localhost:$GH_AW_SAFE_INPUTS_PORT/health",
"Safe Inputs MCP server is ready",
"ERROR: Safe Inputs MCP server failed to start",
}
Expand Down Expand Up @@ -322,11 +322,10 @@ Test readiness check

yamlStr := string(lockContent)

// Verify readiness check loop
// Verify readiness check loop (health endpoint doesn't require auth)
readinessChecks := []string{
"for i in {1..10}; do",
"if curl -s -f -H \"Authorization: Bearer",
"http://localhost:$GH_AW_SAFE_INPUTS_PORT/",
"if curl -s -f http://localhost:$GH_AW_SAFE_INPUTS_PORT/health",
"Safe Inputs MCP server is ready",
"break",
"if [ $i -eq 10 ]; then",
Expand Down
Loading