Skip to content

Remove Claude engine output.txt handling as CLI no longer produces this file#834

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-594adc47-3cf1-40c9-80e4-d515f112096b
Sep 15, 2025
Merged

Remove Claude engine output.txt handling as CLI no longer produces this file#834
pelikhan merged 2 commits intomainfrom
copilot/fix-594adc47-3cf1-40c9-80e4-d515f112096b

Conversation

Copy link
Contributor

Copilot AI commented Sep 15, 2025

The Claude CLI no longer produces an output.txt file, but the Claude agentic engine was still declaring it as an output file. This caused the workflow compiler to generate unnecessary upload and cleanup steps for a file that doesn't exist.

Problem

When using the Claude engine, generated workflows included these unnecessary steps:

  • Upload engine output files step attempting to upload output.txt
  • Clean up engine output files step attempting to remove output.txt
  • agent_outputs artifact creation for non-existent files

This resulted in workflows that tried to handle files that the Claude CLI no longer produces, leading to unnecessary complexity and potential confusion.

Solution

Updated ClaudeEngine.GetDeclaredOutputFiles() to return an empty list instead of []string{"output.txt"}. This prevents the workflow compiler from generating the upload and cleanup steps since there are no declared output files.

The change is minimal and surgical:

  • Only affects Claude engine output file declarations
  • Preserves all other Claude engine functionality
  • Maintains GITHUB_AW_SAFE_OUTPUTS functionality for safe outputs handling
  • Updated corresponding tests to reflect the new expected behavior

Verification

  • All existing tests pass with updated expectations
  • Manual workflow compilation confirms no more unnecessary upload/cleanup steps
  • Generated workflows are cleaner and more efficient
  • Safe outputs functionality remains fully intact

This fix aligns the code with the current behavior of the Claude CLI and eliminates unnecessary workflow steps.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.contoso.com
    • Triggering command: /tmp/go-build15137770/b279/cli.test -test.testlogfile=/tmp/go-build15137770/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
    • Triggering command: /tmp/go-build1084126533/b279/cli.test -test.testlogfile=/tmp/go-build1084126533/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
    • Triggering command: /tmp/go-build1885715907/b279/cli.test -test.testlogfile=/tmp/go-build1885715907/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…is file

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] @copilot the Claude cli does not produce a output.txt file anymore. Update the Claude agentic engine to remove the steps that upload and clean output.txt Remove Claude engine output.txt handling as CLI no longer produces this file Sep 15, 2025
Copilot AI requested a review from pelikhan September 15, 2025 23:30
@pelikhan pelikhan marked this pull request as ready for review September 15, 2025 23:44
@pelikhan pelikhan merged commit 6f126ee into main Sep 15, 2025
11 of 17 checks passed
@pelikhan pelikhan deleted the copilot/fix-594adc47-3cf1-40c9-80e4-d515f112096b branch September 15, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants